Skip to content

Commit fe919e5

Browse files
committed
update comments
1 parent 98ed880 commit fe919e5

File tree

4 files changed

+43
-13
lines changed

4 files changed

+43
-13
lines changed

pom.xml

-3
Original file line numberDiff line numberDiff line change
@@ -270,9 +270,6 @@
270270
<goals>
271271
<goal>jar</goal>
272272
</goals>
273-
<configuration>
274-
<additionalparam>-Xdoclint:none</additionalparam>
275-
</configuration>
276273
</execution>
277274
</executions>
278275
</plugin>

src/main/java/cn/jpush/api/JPushClient.java

+14-1
Original file line numberDiff line numberDiff line change
@@ -950,12 +950,13 @@ public DefaultResult bindMobile(String registrationId, String mobile)
950950
}
951951

952952
// ----------------------- Schedule
953-
954953
/**
955954
* Create a single schedule.
956955
* @param name The schedule name.
957956
* @param time The push time, format is 'yyyy-MM-dd HH:mm:ss'
958957
* @param push The push payload.
958+
* @param masterSecret master secret
959+
* @param appKey app key
959960
* @return The created scheduleResult instance.
960961
* @throws APIConnectionException if a remote or network exception occurs.
961962
* @throws APIRequestException if a request exception occurs.
@@ -983,6 +984,8 @@ public ScheduleResult createSingleSchedule(String name, String time, PushPayload
983984
* @param end The schedule expiration date, format 'yyyy-MM-dd HH:mm:ss'.
984985
* @param time The push time, format 'HH:mm:ss'
985986
* @param push The push payload.
987+
* @param masterSecret master secret
988+
* @param appKey app key
986989
* @return The created scheduleResult instance.
987990
* @throws APIConnectionException if a remote or network exception occurs.
988991
* @throws APIRequestException if a request exception occurs.
@@ -1002,6 +1005,8 @@ public ScheduleResult createDailySchedule(String name, String start, String end,
10021005
* @param time The push time, format 'HH:mm:ss'
10031006
* @param frequency The custom frequency.
10041007
* @param push The push payload.
1008+
* @param masterSecret master secret
1009+
* @param appKey app key
10051010
* @return The created scheduleResult instance.
10061011
* @throws APIConnectionException if a remote or network exception occurs.
10071012
* @throws APIRequestException if a request exception occurs.
@@ -1021,6 +1026,8 @@ public ScheduleResult createDailySchedule(String name, String start, String end,
10211026
* @param time The push time, format 'HH:mm:ss'
10221027
* @param days The appointed days.
10231028
* @param push The push payload.
1029+
* @param masterSecret master secret
1030+
* @param appKey app key
10241031
* @return The created scheduleResult instance.
10251032
* @throws APIConnectionException if a remote or network exception occurs.
10261033
* @throws APIRequestException if a request exception occurs.
@@ -1047,6 +1054,8 @@ public ScheduleResult createWeeklySchedule(String name, String start, String end
10471054
* @param frequency The custom frequency.
10481055
* @param days The appointed days.
10491056
* @param push The push payload.
1057+
* @param masterSecret master secret
1058+
* @param appKey app key
10501059
* @return The created scheduleResult instance.
10511060
* @throws APIConnectionException if a remote or network exception occurs.
10521061
* @throws APIRequestException if a request exception occurs.
@@ -1071,6 +1080,8 @@ public ScheduleResult createWeeklySchedule(String name, String start, String end
10711080
* @param time The push time, format 'HH:mm:ss'.
10721081
* @param points The appointed days.
10731082
* @param push The push payload.
1083+
* @param masterSecret master secret
1084+
* @param appKey app key
10741085
* @return The created scheduleResult instance.
10751086
* @throws APIConnectionException if a remote or network exception occurs.
10761087
* @throws APIRequestException if a request exception occurs.
@@ -1091,6 +1102,8 @@ public ScheduleResult createMonthlySchedule(String name, String start, String en
10911102
* @param frequency The custom frequency.
10921103
* @param points The appointed days.
10931104
* @param push The push payload.
1105+
* @param masterSecret master secret
1106+
* @param appKey app key
10941107
* @return The created scheduleResult instance.
10951108
* @throws APIConnectionException if a remote or network exception occurs.
10961109
* @throws APIRequestException if a request exception occurs.

src/main/java/cn/jpush/api/admin/AdminClient.java

+7-8
Original file line numberDiff line numberDiff line change
@@ -97,14 +97,13 @@ public AppResult deleteApp(String appKey) throws APIConnectionException, APIRequ
9797

9898
/**
9999
* Upload certificate
100-
* @param appKey
101-
* @param devCertificatePassword
102-
* @param proCertificatePassword
103-
* @param devCertificateFile
104-
* @param proCertificateFile
105-
* @return
106-
* @throws APIConnectionException
107-
* @throws APIRequestException
100+
* @param appKey app key
101+
* @param devCertificatePassword dev certificate password
102+
* @param proCertificatePassword pro certificate password
103+
* @param devCertificateFile dev certificate file
104+
* @param proCertificateFile pro certificate file
105+
* @throws APIConnectionException connect exception
106+
* @throws APIRequestException request exception
108107
*/
109108
public void uploadCertificate(String appKey, String devCertificateFile, String devCertificatePassword,
110109
String proCertificateFile, String proCertificatePassword)

src/main/java/cn/jpush/api/image/ImageClient.java

+22-1
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,13 @@ public ImageClient(String masterSecret, String appKey, HttpProxy proxy, ClientCo
4949
this._httpClient = new NativeHttpClient(authCode, proxy, conf);
5050
}
5151

52+
5253
/**
5354
* Upload image by url. Require at least one non-null url.
55+
* @param imageUrlPayload image url payload
56+
* @return {@link ImageUploadResult}
57+
* @throws APIConnectionException connect exception
58+
* @throws APIRequestException request exception
5459
*/
5560
public ImageUploadResult uploadImage(ImageUrlPayload imageUrlPayload)
5661
throws APIConnectionException, APIRequestException {
@@ -72,8 +77,13 @@ public ImageUploadResult uploadImage(ImageUrlPayload imageUrlPayload)
7277

7378
/**
7479
* Upload image by file. Require at least 1 non-null fileName. Currently only support Xiaomi and OPPO
80+
* @param imageFilePayload image file payload
81+
* @return {@link ImageUploadResult}
82+
* @throws APIConnectionException connect exception
83+
* @throws APIRequestException request exception
7584
*/
76-
public ImageUploadResult uploadImage(ImageFilePayload imageFilePayload) {
85+
public ImageUploadResult uploadImage(ImageFilePayload imageFilePayload)
86+
throws APIConnectionException, APIRequestException{
7787
Preconditions.checkArgument(imageFilePayload.getImageType() != null, "Image type should not be null");
7888
checkImageFilePayload(imageFilePayload);
7989
NativeHttpClient client = (NativeHttpClient) _httpClient;
@@ -99,6 +109,11 @@ public ImageUploadResult uploadImage(ImageFilePayload imageFilePayload) {
99109

100110
/**
101111
* Modify image by url. Require at least one non-null url.
112+
* @param mediaId media id
113+
* @param imageUrlPayload image url payload
114+
* @return {@link ImageUploadResult}
115+
* @throws APIConnectionException connection exception
116+
* @throws APIRequestException request exception
102117
*/
103118
public ImageUploadResult modifyImage(String mediaId, ImageUrlPayload imageUrlPayload)
104119
throws APIConnectionException, APIRequestException {
@@ -118,8 +133,14 @@ public ImageUploadResult modifyImage(String mediaId, ImageUrlPayload imageUrlPay
118133
return imageUploadResult;
119134
}
120135

136+
121137
/**
122138
* Modify image by file. Require at least 1 non-null fileName. Currently only support Xiaomi and OPPO
139+
* @param mediaId media id
140+
* @param imageFilePayload image file payload
141+
* @return {@link ImageUploadResult}
142+
* @throws APIConnectionException connection exception
143+
* @throws APIRequestException request exception
123144
*/
124145
public ImageUploadResult modifyImage(String mediaId, ImageFilePayload imageFilePayload) {
125146
Preconditions.checkArgument(StringUtils.isNotEmpty(mediaId), "mediaId should not be empty");

0 commit comments

Comments
 (0)