Adding tests (some commented for now) and fixing typos following comments

Author: fguitton

lib/TextDecoder-impl.js

@@ -3,21 +3,18 @@
 const { labelToName, isSupported, decode } = require("./whatwg-encoding");
 
 exports.implementation = class TextDecoderImpl {
-  constructor(globalObject, constructorArgs = []) {
-    const label = constructorArgs[0];
-    const options = constructorArgs[1] || {};
-
+  constructor(globalObject, [label, options = {}]) {
     const encoding = labelToName(label);
-    if (!isSupported(encoding) || encoding === "replacement") {
-      throw new RangeError(`"${encoding}" is not a supported encoding name`);
+    if (encoding === null || !isSupported(encoding) || encoding === "replacement") {
+      throw new RangeError(`"${label}" is not a supported encoding name`);
     }
     this._encoding = encoding;
-    this._errorMode = options._fatal ? "fatal" : "replacement";
-    this._ignoreBOM = options._ignoreBOM || false;
+    this._errorMode = options.fatal === true ? "fatal" : "replacement";
+    this._ignoreBOM = options.ignoreBOM || false;
   }
 
   get encoding() {
-    return String(this._encoding).toLowerCase();
+    return this._encoding.toLowerCase();
   }
 
   get fatal() {
@@ -29,12 +26,12 @@ exports.implementation = class TextDecoderImpl {
   }
 
   decode(input, options = {}) {
-    if (options.steam === true) {
+    if (options.stream === true) {
       // TODO: Implement stream support
     }
     try {
       // TODO: Implement ignoreBOM support
-      return decode(Buffer.from(input), this._encoding);
+      return decode(Buffer.from(input), this._encoding, this._ignoreBOM);
     } catch (exception) {
       if (this._errorMode === "fatal") {
         throw new TypeError(exception);

lib/TextEncoder-impl.js

@@ -15,7 +15,7 @@ exports.implementation = class TextEncoderImpl {
     return encode(Buffer.from(input));
   }
 
-  encodeInto(source, destination) {
+  encodeInto(/* source, destination */) {
     // TODO Implement stream copy support
   }
 };

lib/whatwg-encoding.js

@@ -13,20 +13,23 @@ exports.labelToName = label => {
 };
 
 // https://encoding.spec.whatwg.org/#decode
-exports.decode = (buffer, fallbackEncodingName) => {
+exports.decode = (buffer, fallbackEncodingName, ignoreBOM) => {
   let encoding = fallbackEncodingName;
   if (!exports.isSupported(encoding)) {
     throw new RangeError(`"${encoding}" is not a supported encoding name`);
   }
 
   const bomEncoding = exports.getBOMEncoding(buffer);
-  if (bomEncoding !== null) {
+  if (!ignoreBOM && bomEncoding !== null) {
     encoding = bomEncoding;
   }
 
   // iconv-lite will strip BOMs for us, so no need to do the stuff the spec does
+  const decodeOptions = {
+    stripBOM: !ignoreBOM
+  };
 
-  return iconvLite.decode(buffer, encoding);
+  return iconvLite.decode(buffer, encoding, decodeOptions);
 };
 
 

scripts/get-latest-platform-tests.js

@@ -30,9 +30,23 @@ const targetDir = path.resolve(__dirname, "..", "test", "web-platform-tests");
 
 for (const file of [
   "api-basics.any.js",
+  // "api-invalid-label.any.js",
+  "api-replacement-encodings.any.js",
   "api-surrogates-utf8.any.js",
-  // "textdecoder-ignorebom.any.js",
-  "textencoder-utf16-surrogates.any.js"
+  // "encodeInto.any.js",
+  // "replacement-encodings.any.js",
+  "textdecoder-byte-order-marks.any.js",
+  // "textdecoder-copy.any.js",
+  // "textdecoder-fatal-single-byte.any.js",
+  // "textdecoder-fatal-streaming.any.js",
+  // "textdecoder-fatal.any.js",
+  "textdecoder-ignorebom.any.js",
+  // "textdecoder-labels.any.js",
+  // "textdecoder-streaming.any.js",
+  // "textdecoder-utf16-surrogates.any.js"
+  // "textencoder-constructor-non-utf.any.js",
+  // "textencoder-utf16-surrogates.any.js",
+  // "unsupported-encodings.any.js"
 ]) {
   pipeline(
     got.stream(`${urlPrefix}${file}`),

test/testharness.js

@@ -11,6 +11,10 @@ module.exports = {
     // No-op; the only place this is used in WPT is not applicable to our usage.
   },
 
+  subsetTest(testFunc, ...args) {
+    return testFunc(...args);
+  },
+
   assert_true(actual) {
     assert.strictEqual(actual, true);
   },
@@ -23,6 +27,10 @@ module.exports = {
     assert.strictEqual(actual, expected);
   },
 
+  assert_not_equals(actual, expected) {
+    assert.notEqual(actual, expected);
+  },
+
   assert_array_equals(actual, expected) {
     assert.deepStrictEqual([...actual], [...expected]);
   },
@@ -31,6 +39,10 @@ module.exports = {
     assert.throws(func);
   },
 
+  assert_throws_js(code, func) {
+    assert.throws(func);
+  },
+
   assert_unreached() {
     assert(false);
   }