Skip to content

package headers should have a minimum height so nav doesn't move #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
donjo opened this issue Apr 16, 2024 · 1 comment · May be fixed by #1052
Open

package headers should have a minimum height so nav doesn't move #386

donjo opened this issue Apr 16, 2024 · 1 comment · May be fixed by #1052
Assignees
Labels

Comments

@donjo
Copy link
Member

donjo commented Apr 16, 2024

Screenshot 2024-04-16 at 9 54 27 AM Screenshot 2024-04-16 at 9 54 12 AM

If you're browsing a package with a short or non-existent description clicking a tab that isn't tied to a specific package version, like the score tab, will cause the UI to shift around since the "published" content block is no longer displaying. The overall header should probably have a minimum height set to whatever the shortest possible header with a published date is.

@blackwatertepes
Copy link

Wouldn't it be better to keep the "published" content block across all tabs, instead of it disappearing?

@lucacasonato lucacasonato moved this from Needs Triage to Ready in JSR Nov 8, 2024
@crowlKats crowlKats removed the bug label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Ready
Development

Successfully merging a pull request may close this issue.

3 participants