Skip to content

Support for stream-level ToS/TC #4848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akrisfx opened this issue Feb 24, 2025 · 5 comments
Open

Support for stream-level ToS/TC #4848

akrisfx opened this issue Feb 24, 2025 · 5 comments
Labels
Area: API external Proposed by non-MSFT feature request A request for new functionality
Milestone

Comments

@akrisfx
Copy link

akrisfx commented Feb 24, 2025

Describe the feature you'd like supported

Just support for stream-level ToS/TC for more precise prioritization of network traffic

Proposed solution

There will be no need to be afraid that some vital messages will not reach the consumer. And simplification of this mechanism, because now it is possible only within the framework of different connections

Additional context

No response

@akrisfx akrisfx added the feature request A request for new functionality label Feb 24, 2025
@nibanks nibanks added this to the Future milestone Feb 25, 2025
@nibanks nibanks added external Proposed by non-MSFT Area: API labels Feb 25, 2025
@QWERerRus
Copy link

@akrisfx
Copy link
Author

akrisfx commented Apr 21, 2025

Hi @nibanks and @anrossi , can you estimate the difficulty of this task? And the chance that I can write it by myself

Now I'm trying to analyze the possibility of making different DSCP from different streams without changing the flow much.

And the question: in QuicSendFlush, we send data by splitting it into data from different Streams (as a result, we can set DHCP at this level), or everything is sent at once in a large batch with a single DSCP to different Streams.

@nibanks
Copy link
Member

nibanks commented Apr 21, 2025

Hi @nibanks and @anrossi , can you estimate the difficulty of this task? And the chance that I can write it by myself

If you go with a best effort approach where you only set the non-default DCSP flag if the packet only ends up having the stream you care about (no other streams or control data; i.e. one single frame), then it might be quite easy to support. So, I'd recommend starting with that design, and if you need more, iterate with follow up PRs.

@nibanks nibanks moved this to Planned in DPT Iteration Tracker Apr 24, 2025
@nibanks
Copy link
Member

nibanks commented May 2, 2025

@akrisfx are you working on this?

@akrisfx
Copy link
Author

akrisfx commented May 3, 2025

My lead is still trying to solve this problem with priorities, so not yet. I only managed to create a DSCP field in the stream in my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: API external Proposed by non-MSFT feature request A request for new functionality
Projects
Status: Planned
Development

No branches or pull requests

3 participants