Skip to content

CMake Configuration Issues on MacOS #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Darce-One opened this issue Mar 19, 2025 · 2 comments
Open

CMake Configuration Issues on MacOS #64

Darce-One opened this issue Mar 19, 2025 · 2 comments

Comments

@Darce-One
Copy link
Contributor

Darce-One commented Mar 19, 2025

Description

The current configuration of the CMakeLists.txt file does not support successful project builds on MacOS. This was verified using the build_and_run.sh script located in the example folder.

Workaround

I have implemented a workaround by bypassing the tokenizers_cpp_objs target and building the tokenizers_cpp target directly, which resolved the issue. Additionally, I included a find_executable command to locate the cargo executable at compile time and replaced the hardcoded cargo path with a variable. This change enhances the build process, particularly when working within Xcode.

Pull Request

I am preparing a Pull Request #65 to incorporate these modifications into the main branch.

@springkim
Copy link

@Darce-One

How about trying out a recently developed tokenizer library?
It's written in C++, supports all major operating systems, and provides extremely fast tokenization performance.
You can check it out here: https://github.com/NLPOptimize/flash-tokenizer

@Darce-One
Copy link
Contributor Author

@Darce-One

How about trying out a recently developed tokenizer library? It's written in C++, supports all major operating systems, and provides extremely fast tokenization performance. You can check it out here: https://github.com/NLPOptimize/flash-tokenizer

@springkim Thanks for the recommendation. It looks good, I'll try it out. Do you plan to keep supporting it in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants