Skip to content

dRAID comment error #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edgarsuit opened this issue Nov 25, 2023 · 0 comments
Open

dRAID comment error #474

edgarsuit opened this issue Nov 25, 2023 · 0 comments
Labels
openzfs/zfs repo Something related to main code repository of project

Comments

@edgarsuit
Copy link

The comment at the top of draid.c has an error (unless I'm reading it wrong): https://github.com/openzfs/zfs/blob/a94860a6dee1c07bb96ee36dafcba40b804560cc/module/zfs/vdev_draid.c#L77C48-L77C48

It says the number of redundancy groups in a slice is LCM(D+P, C-S). For the example, it shows a draid1:8d:14c:2s configuration. LCM(8+1, 14-2) = 36, which is not how many redundancy groups are in the slice (the diagram shows 4).

The number of redundancy groups in the slice is LCM(D+P, C-S)/(D+P).

The number of rows in the slice is LCM(D+P, C-S)/(C-S).

@gmelikov gmelikov added the openzfs/zfs repo Something related to main code repository of project label Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openzfs/zfs repo Something related to main code repository of project
Projects
None yet
Development

No branches or pull requests

2 participants