Skip to content

Commit c6845d9

Browse files
committed
Remove debugging statements from node.js.yml. Update release.yml to use the same protoc installation method and remove dependency on third-party npm publisher.
1 parent 682ca3e commit c6845d9

File tree

2 files changed

+9
-13
lines changed

2 files changed

+9
-13
lines changed

.github/workflows/node.js.yml

-2
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,6 @@ jobs:
3737
- run: curl -LO "https://github.com/protocolbuffers/protobuf/releases/download/v3.13.0/protoc-3.13.0-linux-x86_64.zip"
3838
- run: unzip protoc-3.13.0-linux-x86_64.zip -d /tmp/grpc
3939
- run: echo "/tmp/grpc/bin" >> $GITHUB_PATH
40-
- run: ls /tmp/grpc/bin
41-
- run: echo $PATH
4240
# install project deps
4341
- run: npm install
4442
# start test container

.github/workflows/release.yml

+9-11
Original file line numberDiff line numberDiff line change
@@ -31,29 +31,27 @@ jobs:
3131
node-version: 14.x
3232
# Specifies the registry, this field is required!
3333
registry-url: https://registry.npmjs.org/
34-
# use "npm ci" to avoid package lock changes
35-
- name: Install Protoc
36-
uses: arduino/setup-protoc@v1
34+
# install protoc
35+
- run: curl -LO "https://github.com/protocolbuffers/protobuf/releases/download/v3.13.0/protoc-3.13.0-linux-x86_64.zip"
36+
- run: unzip protoc-3.13.0-linux-x86_64.zip -d /tmp/grpc
37+
- run: echo "/tmp/grpc/bin" >> $GITHUB_PATH
3738
- run: npm install
3839
# start test container
3940
- run: npm run coh-up
4041
# compile grpc stubs
4142
- run: npm run grpc
4243
# give the container time to bootstrap
43-
- name: Sleep for 30 seconds
44-
uses: jakejarvis/wait-action@master
45-
with:
46-
time: '30s'
44+
- run: npm run wait
4745
# run the tests
4846
- run: npm run test
4947
# top the test container
5048
- run: npm run coh-down
5149
# clean up
5250
- run: npm run coh-clean
53-
- run: npm install typedoc
51+
- run: npm install --no-save typedoc
5452
# generate dist which runs other tasks
5553
- run: npm run dist
5654
# publish to NPM
57-
- uses: JS-DevTools/npm-publish@v1
58-
with:
59-
token: ${{ secrets.NPM_PUBLISH_KEY }}
55+
- run: npm publish
56+
env:
57+
NODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_KEY }}

0 commit comments

Comments
 (0)