Skip to content

REGR: Fix signature of GroupBy.expanding #61361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rhshadrach opened this issue Apr 26, 2025 · 2 comments
Open

REGR: Fix signature of GroupBy.expanding #61361

rhshadrach opened this issue Apr 26, 2025 · 2 comments
Labels
Blocker Blocking issue or pull request for an upcoming release Bug Groupby Regression Functionality that used to work in a prior pandas version Window rolling, ewma, expanding
Milestone
3.0

Comments

@rhshadrach
Copy link
Member

rhshadrach commented Apr 26, 2025 •
edited
Loading

Ref: #61352 (comment)

#61352 replaced *args and **kwargs in the signature of GroupBy.expanding. However I believe further arguments need to be added. We could also revert the PR instead.
@rhshadrach rhshadrach added Blocker Blocking issue or pull request for an upcoming release Bug Groupby Regression Functionality that used to work in a prior pandas version Window rolling, ewma, expanding labels Apr 26, 2025
@rhshadrach rhshadrach added this to the 3.0 milestone Apr 26, 2025
@rhshadrach rhshadrach mentioned this issue Apr 26, 2025
Merged
5 tasks
@arthurlw
Copy link
Contributor

Thanks for pointing this out! Just to confirm, which additional arguments do you think should be included in the signature/documentation?

@rhshadrach
Copy link
Member Author

From the old docstrings:

Arguments are the same as :meth:DataFrame.rolling except that step cannot be specified.

I believe that's accurate, but we should confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Blocker Blocking issue or pull request for an upcoming release Bug Groupby Regression Functionality that used to work in a prior pandas version Window rolling, ewma, expanding
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
2 participants
@rhshadrach @arthurlw