publishing listing creates bidding

Author: pgorecki

.idea/.gitignore

@@ -4,24 +4,25 @@
 from fastapi.responses import JSONResponse
 
 import api.routers.catalog
-from api.models import CurrentUser
-from api.routers import catalog, iam
+from api.models.catalog import CurrentUser
+from api.routers import bidding, catalog, iam
 from config.api_config import ApiConfig
 from config.container import Container
 from seedwork.domain.exceptions import DomainException, EntityNotFoundException
 from seedwork.infrastructure.logging import LoggerFactory, logger
 from seedwork.infrastructure.request_context import request_context
 
 # configure logger prior to first usage
-LoggerFactory.configure(logger_name="cli")
+LoggerFactory.configure(logger_name="api")
 
 # dependency injection container
 container = Container()
 container.config.from_pydantic(ApiConfig())
-container.wire(modules=[api.routers.catalog, api.routers.iam])
+container.wire(modules=[api.routers.catalog, api.routers.bidding, api.routers.iam])
 
 app = FastAPI(debug=container.config.DEBUG)
 app.include_router(catalog.router)
+app.include_router(bidding.router)
 app.include_router(iam.router)
 app.container = container
 

.idea/inspectionProfiles/Project_Default.xml

@@ -0,0 +1,18 @@
+from datetime import datetime
+from uuid import UUID
+
+from pydantic import BaseModel
+
+
+class BidReadModel(BaseModel):
+    amount: float
+    currency: str
+    bidder_id: UUID
+    bidder_username: str
+
+
+class BiddingReadModel(BaseModel):
+    listing_id: UUID
+    auction_status: str = "active"  # active, ended
+    auction_end_date: datetime
+    bids: list[BidReadModel]

.idea/inspectionProfiles/profiles_settings.xml

@@ -19,6 +19,10 @@ class ListingWriteModel(BaseModel):
     ask_price_currency: str = "USD"
 
 
+class ListingPublishModel(BaseModel):
+    id: UUID
+
+
 class ListingReadModel(BaseModel):
     id: UUID
     title: str = ""

.idea/modules.xml

@@ -0,0 +1,12 @@
+from uuid import UUID, uuid4
+
+from pydantic import BaseModel
+
+
+class CurrentUser(BaseModel):
+    id: UUID
+    username: str
+
+    @classmethod
+    def fake_user(cls):
+        return CurrentUser(id=uuid4(), username="fake_user")

.idea/vcs.xml

@@ -0,0 +1,32 @@
+from fastapi import APIRouter
+
+from api.models.bidding import BiddingReadModel
+from api.shared import dependency
+from config.container import Container, inject
+from modules.bidding.application.query.get_bidding_details import GetBiddingDetails
+from seedwork.application import Application
+
+router = APIRouter()
+
+"""
+Inspired by https://developer.ebay.com/api-docs/buy/offer/types/api:Bidding
+"""
+
+
+@router.get("/bidding/{listing_id}", tags=["bidding"], response_model=BiddingReadModel)
+@inject
+async def get_bidding_details_of_listing(
+    listing_id,
+    app: Application = dependency(Container.application),
+):
+    """
+    Shows listing details
+    """
+    query = GetBiddingDetails(listing_id=listing_id)
+    query_result = app.execute_query(query)
+    payload = query_result.payload
+    return BiddingReadModel(
+        listing_id=str(payload.id),
+        auction_end_date=payload.ends_at,
+        bids=payload.bids,
+    )

src/api/main.py

@@ -1,18 +1,23 @@
 from fastapi import APIRouter
 
-from api.models import ListingIndexModel, ListingReadModel, ListingWriteModel
+from api.models.catalog import ListingIndexModel, ListingReadModel, ListingWriteModel
 from api.shared import dependency
 from config.container import Container, inject
 from modules.catalog.application.command import (
     CreateListingDraftCommand,
     DeleteListingDraftCommand,
+    PublishListingDraftCommand,
 )
 from modules.catalog.application.query.get_all_listings import GetAllListings
 from modules.catalog.application.query.get_listing_details import GetListingDetails
 from seedwork.application import Application
 from seedwork.domain.value_objects import Money
 from seedwork.infrastructure.request_context import request_context
 
+"""
+Inspired by https://developer.ebay.com/api-docs/sell/inventory/resources/offer/methods/createOffer
+"""
+
 router = APIRouter()
 
 
@@ -64,7 +69,7 @@ async def create_listing(
 
     query = GetListingDetails(listing_id=command_result.payload)
     query_result = app.execute_query(query)
-    return dict(data=query_result.payload)
+    return dict(query_result.payload)
 
 
 @router.delete(
@@ -82,3 +87,27 @@ async def delete_listing(
         listing_id=listing_id,
     )
     app.execute_command(command)
+
+
+@router.post(
+    "/catalog/{listing_id}/publish",
+    tags=["catalog"],
+    status_code=200,
+    response_model=ListingReadModel,
+)
+@inject
+async def publish_listing(
+    listing_id,
+    app: Application = dependency(Container.application),
+):
+    """
+    Creates a new listing.
+    """
+    command = PublishListingDraftCommand(
+        listing_id=listing_id,
+    )
+    command_result = app.execute_command(command)
+
+    query = GetListingDetails(listing_id=command_result.entity_id)
+    query_result = app.execute_query(query)
+    return dict(query_result.payload)

src/api/models/__init__.py

@@ -1,6 +1,9 @@
 import pytest
 
-from modules.catalog.application.command import CreateListingDraftCommand
+from modules.catalog.application.command import (
+    CreateListingDraftCommand,
+    PublishListingDraftCommand,
+)
 from seedwork.domain.value_objects import UUID, Money
 
 
@@ -107,3 +110,45 @@ def test_catalog_delete_non_existing_draft_returns_404(api, api_client):
     listing_id = UUID("00000000000000000000000000000001")
     response = api_client.delete(f"/catalog/{listing_id}")
     assert response.status_code == 404
+
+
+@pytest.mark.integration
+def test_catalog_publish_listing_draft(api, api_client):
+    # arrange
+    app = api.container.application()
+    command_result = app.execute_command(
+        CreateListingDraftCommand(
+            title="Foo to be deleted",
+            description="Bar",
+            ask_price=Money(10),
+            seller_id=UUID("00000000000000000000000000000002"),
+        )
+    )
+
+    # act
+    response = api_client.post(f"/catalog/{command_result.entity_id}/publish")
+
+    # assert that the listing was published
+    assert response.status_code == 200
+
+
+def test_published_listing_appears_in_biddings(api, api_client):
+    # arrange
+    app = api.container.application()
+    command_result = app.execute_command(
+        CreateListingDraftCommand(
+            title="Foo to be deleted",
+            description="Bar",
+            ask_price=Money(10),
+            seller_id=UUID("00000000000000000000000000000002"),
+        )
+    )
+    command_result = app.execute_command(
+        PublishListingDraftCommand(
+            listing_id=command_result.entity_id,
+        )
+    )
+
+    url = f"/bidding/{command_result.entity_id}"
+    response = api_client.get(url)
+    assert response.status_code == 200

src/api/models/bidding.py

@@ -2,6 +2,7 @@
 from dependency_injector.wiring import inject  # noqa
 from sqlalchemy import create_engine
 
+from modules.bidding import BiddingModule
 from modules.catalog import CatalogModule
 from modules.iam import IamModule
 from seedwork.application import Application
@@ -48,15 +49,17 @@ def create_engine_once(config):
     return engine
 
 
-def create_app(name, version, config, engine, catalog_module, outbox) -> Application:
+def create_app(
+    name, version, config, engine, catalog_module, bidding_module, outbox
+) -> Application:
     app = Application(
         name=name,
         version=version,
         config=config,
         engine=engine,
         outbox=outbox,
     )
-    app.add_module("catalog", catalog_module)
+    app.add_modules(catalog=catalog_module, bidding=bidding_module)
     return app
 
 
@@ -76,6 +79,10 @@ class Container(containers.DeclarativeContainer):
         CatalogModule,
     )
 
+    bidding_module = providers.Factory(
+        BiddingModule,
+    )
+
     iam_module = providers.Factory(
         IamModule,
     )
@@ -87,5 +94,6 @@ class Container(containers.DeclarativeContainer):
         config=config,
         engine=engine,
         catalog_module=catalog_module,
+        bidding_module=bidding_module,
         outbox=outbox,
     )

src/api/models.py renamed to src/api/models/catalog.py

@@ -1,5 +1,6 @@
 from modules.bidding.application.command import PlaceBidCommand, RetractBidCommand
-from modules.bidding.application.query import GetPastdueListingsQuery
+from modules.bidding.application.event import when_listing_is_published_start_auction
+from modules.bidding.application.query import GetBiddingDetails, GetPastdueListings
 from modules.bidding.infrastructure.listing_repository import (
     PostgresJsonListingRepository,
 )
@@ -8,8 +9,8 @@
 
 class BiddingModule(BusinessModule):
     supported_commands = (PlaceBidCommand, RetractBidCommand)
-    supported_queries = (GetPastdueListingsQuery,)
-    supported_events = ()
+    supported_queries = (GetPastdueListings, GetBiddingDetails)
+    event_handlers = (when_listing_is_published_start_auction,)
 
     def configure_unit_of_work(self, uow):
         """Here we have a chance to add extra UOW attributes to be injected into command/query handlers"""

src/api/models/common.py

@@ -0,0 +1,19 @@
+from datetime import datetime, timedelta
+
+from modules.bidding.domain.entities import Listing
+from modules.bidding.domain.value_objects import Seller
+from modules.catalog.domain.events import ListingPublishedEvent
+from seedwork.application.decorators import domain_event_handler
+
+
+@domain_event_handler
+def when_listing_is_published_start_auction(
+    event: ListingPublishedEvent, listing_repository
+):
+    listing = Listing(
+        id=event.listing_id,
+        seller=Seller(id=event.seller_id),
+        initial_price=event.ask_price,
+        ends_at=datetime.now() + timedelta(days=7),
+    )
+    listing_repository.add(listing)

src/api/routers/bidding.py

@@ -1 +1,2 @@
-from .get_pastdue_listings import GetPastdueListingsQuery
+from .get_bidding_details import GetBiddingDetails
+from .get_pastdue_listings import GetPastdueListings