Skip to content

Commit 633ff31

Browse files
authored
Merge pull request #220 from phpcr/jackalope-2
upgrade jackalope to version 2
2 parents c5e62c9 + b59ba0d commit 633ff31

File tree

4 files changed

+12
-7
lines changed

4 files changed

+12
-7
lines changed

.github/workflows/test-application.yaml

+3-3
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,11 @@ jobs:
5959

6060
steps:
6161
- name: Checkout project
62-
uses: actions/checkout@v2
62+
uses: actions/checkout@v4
6363

6464
# default java installation not able to run jackrabbit. use same as jackalope-jackrabbit action
6565
- name: Install and configure Java
66-
uses: actions/setup-java@v3
66+
uses: actions/setup-java@v4
6767
with:
6868
distribution: temurin
6969
java-version: '8'
@@ -82,7 +82,7 @@ jobs:
8282

8383
- name: Cache Jackrabbit
8484
id: cache-jackrabbit
85-
uses: actions/cache@v3
85+
uses: actions/cache@v4
8686
with:
8787
path: vendor/jackalope/jackalope-jackrabbit/bin/jackrabbit-standalone-*
8888
key: jackrabbit

CHANGELOG.md

+5
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
Changelog
22
=========
33

4+
1.6.0
5+
-----
6+
7+
- Work with Jackalope 2.*.
8+
49
1.5.0
510
-----
611

composer.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"require": {
55
"php": "^8.0",
66
"symfony/console": "^5.0 || ^6.0",
7-
"jackalope/jackalope": "^1.3.4",
7+
"jackalope/jackalope": "^1.3.4 || ^2.0",
88
"phpcr/phpcr": "^2.1",
99
"phpcr/phpcr-utils": "^1.2",
1010
"symfony/finder": "^5.0 || ^6.0",
@@ -18,8 +18,8 @@
1818
"phpunit/phpunit": "^9.5",
1919
"behat/behat": "^3.10",
2020
"phpspec/phpspec": "^7.2",
21-
"jackalope/jackalope-doctrine-dbal": "^1.3",
22-
"jackalope/jackalope-jackrabbit": "^1.4.4",
21+
"jackalope/jackalope-doctrine-dbal": "^1.3 || ^2.0",
22+
"jackalope/jackalope-jackrabbit": "^1.4.4 || ^2.0",
2323
"phpspec/prophecy-phpunit": "^2.0"
2424
},
2525
"suggest": {

src/PHPCR/Shell/Console/Command/Phpcr/LockLockCommand.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ protected function configure(): void
2727
$this->addArgument('path', InputArgument::REQUIRED, 'Path of node to be locked');
2828
$this->addOption('deep', null, InputOption::VALUE_NONE, 'If given this lock will apply to this node and all its descendants; if not, it applies only to this node.');
2929
$this->addOption('session-scoped', null, InputOption::VALUE_NONE, 'If given, this lock expires with the current session; if not it expires when explicitly or automatically unlocked for some other reason');
30-
$this->addOption('timeout', null, InputOption::VALUE_REQUIRED, 'Desired lock timeout in seconds (servers are free to ignore this value). If not used lock will not timeout');
30+
$this->addOption('timeout', null, InputOption::VALUE_REQUIRED, 'Desired lock timeout in seconds (servers are free to ignore this value). If not used lock will not timeout', PHP_INT_MAX);
3131
$this->addOption('owner-info', null, InputOption::VALUE_REQUIRED, ' string containing owner information supplied by the client; servers are free to ignore this value. If none is specified, the implementation chooses one (i.e. user name of current backend authentication credentials');
3232
$this->setHelp(
3333
<<<'HERE'

0 commit comments

Comments
 (0)