Skip to content

Commit af48d23

Browse files
eemelieviljeff
andauthored
Apply suggestions from code review
Co-authored-by: Andrew Williamson <[email protected]>
1 parent 49e540a commit af48d23

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

fluent.runtime/fluent/runtime/bundle.py

+1-4
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,7 @@ def __init__(self,
3737
functions: Union[Dict[str, Callable[[Any], 'FluentType']], None] = None,
3838
use_isolating: bool = True):
3939
self.locales = locales
40-
_functions = BUILTINS.copy()
41-
if functions:
42-
_functions.update(functions)
43-
self._functions = _functions
40+
self._functions = {**BUILTINS, **(functions or {})}
4441
self.use_isolating = use_isolating
4542
self._messages: Dict[str, Union[FTL.Message, FTL.Term]] = {}
4643
self._terms: Dict[str, Union[FTL.Message, FTL.Term]] = {}

fluent.syntax/fluent/syntax/visitor.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def visit(self, node: Any) -> None:
2525
visit(node)
2626

2727
def generic_visit(self, node: BaseNode) -> None:
28-
for _propname, propvalue in vars(node).items():
28+
for propvalue in vars(node).values():
2929
self.visit(propvalue)
3030

3131

0 commit comments

Comments
 (0)