Skip to content
This repository was archived by the owner on Oct 4, 2020. It is now read-only.

Commit 6b3d225

Browse files
committed
Merge pull request #19 from sharkdp/fix-types
Fix types of setId, setClassName, setAttribute and setTextContent
2 parents bffcfdd + 86ad05c commit 6b3d225

File tree

4 files changed

+10
-8
lines changed

4 files changed

+10
-8
lines changed

docs/DOM/Node/Element.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ id :: forall eff. Element -> Eff (dom :: DOM | eff) ElementId
3333
#### `setId`
3434

3535
``` purescript
36-
setId :: forall eff. ElementId -> Element -> Eff (dom :: DOM | eff) ElementId
36+
setId :: forall eff. ElementId -> Element -> Eff (dom :: DOM | eff) Unit
3737
```
3838

3939
#### `className`
@@ -45,7 +45,7 @@ className :: forall eff. Element -> Eff (dom :: DOM | eff) String
4545
#### `setClassName`
4646

4747
``` purescript
48-
setClassName :: forall eff. String -> Element -> Eff (dom :: DOM | eff) String
48+
setClassName :: forall eff. String -> Element -> Eff (dom :: DOM | eff) Unit
4949
```
5050

5151
#### `getElementsByTagName`
@@ -69,7 +69,7 @@ getElementsByClassName :: forall eff. String -> Element -> Eff (dom :: DOM | eff
6969
#### `setAttribute`
7070

7171
``` purescript
72-
setAttribute :: forall eff. String -> String -> Element -> Eff (dom :: DOM | eff) String
72+
setAttribute :: forall eff. String -> String -> Element -> Eff (dom :: DOM | eff) Unit
7373
```
7474

7575
#### `getAttribute`

docs/DOM/Node/Node.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ cases.
139139
#### `setTextContent`
140140

141141
``` purescript
142-
setTextContent :: forall eff. Node -> Eff (dom :: DOM | eff) String
142+
setTextContent :: forall eff. Node -> Eff (dom :: DOM | eff) Unit
143143
```
144144

145145
If the node type is document fragment, element, text, processing

src/DOM/Node/Element.purs

+5-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
module DOM.Node.Element where
22

3+
import Prelude (Unit())
4+
35
import Control.Monad.Eff (Eff())
46

57
import Data.Nullable (Nullable())
@@ -13,13 +15,13 @@ foreign import localName :: Element -> String
1315
foreign import tagName :: Element -> String
1416

1517
foreign import id :: forall eff. Element -> Eff (dom :: DOM | eff) ElementId
16-
foreign import setId :: forall eff. ElementId -> Element -> Eff (dom :: DOM | eff) ElementId
18+
foreign import setId :: forall eff. ElementId -> Element -> Eff (dom :: DOM | eff) Unit
1719
foreign import className :: forall eff. Element -> Eff (dom :: DOM | eff) String
18-
foreign import setClassName :: forall eff. String -> Element -> Eff (dom :: DOM | eff) String
20+
foreign import setClassName :: forall eff. String -> Element -> Eff (dom :: DOM | eff) Unit
1921

2022
foreign import getElementsByTagName :: forall eff. String -> Element -> Eff (dom :: DOM | eff) HTMLCollection
2123
foreign import getElementsByTagNameNS :: forall eff. Nullable String -> String -> Element -> Eff (dom :: DOM | eff) HTMLCollection
2224
foreign import getElementsByClassName :: forall eff. String -> Element -> Eff (dom :: DOM | eff) HTMLCollection
2325

24-
foreign import setAttribute :: forall eff. String -> String -> Element -> Eff (dom :: DOM | eff) String
26+
foreign import setAttribute :: forall eff. String -> String -> Element -> Eff (dom :: DOM | eff) Unit
2527
foreign import getAttribute :: forall eff. String -> Element -> Eff (dom :: DOM | eff) (Nullable String)

src/DOM/Node/Node.purs

+1-1
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ foreign import textContent :: forall eff. Node -> Eff (dom :: DOM | eff) String
7272
-- | If the node type is document fragment, element, text, processing
7373
-- | instruction, or comment this allows the node's data to be changed, or has
7474
-- | no effect in all other cases.
75-
foreign import setTextContent :: forall eff. Node -> Eff (dom :: DOM | eff) String
75+
foreign import setTextContent :: forall eff. Node -> Eff (dom :: DOM | eff) Unit
7676

7777
-- | Removes empty text nodes and then combines any remaining text nodes that
7878
-- | are contiguous.

0 commit comments

Comments
 (0)