Update dependencies and fix Windows compatibility on Python 3.12 #183
Conversation
| "Topic :: Software Development :: Libraries :: Python Modules", | ||
| "Topic :: System :: Hardware :: Hardware Drivers", | ||
| "Topic :: System :: Hardware :: Hardware Drivers :: Smartcard", | ||
| "Topic :: System :: Hardware :: Hardware Drivers :: Token" |
There was a problem hiding this comment.
Only minor comment: please leave the indentation intact. Hard to say what you changed here?
| * /Distributed under the terms of the OASIS IPR Policy, | ||
| * [http://www.oasis-open.org/policies-guidelines/ipr], AS-IS, WITHOUT ANY | ||
| * IMPLIED OR EXPRESS WARRANTY; there is no warranty of MERCHANTABILITY, FITNESS FOR A | ||
| * PARTICULAR PURPOSE or NONINFRINGEMENT of the rights of others. | ||
| */ | ||
|
|
||
| /* Latest version of the specification: | ||
| * http://docs.oasis-open.org/pkcs11/pkcs11-base/v2.40/pkcs11-base-v2.40.html | ||
| /* | ||
| * PKCS #11 Specification Version 3.1 | ||
| * OASIS Standard | ||
| * 23 July 2023 | ||
| * Copyright (c) OASIS Open 2023. All Rights Reserved. | ||
| * Source: https://docs.oasis-open.org/pkcs11/pkcs11-spec/v3.1/os/include/pkcs11-v3.1/ | ||
| * Latest stage of narrative specification: https://docs.oasis-open.org/pkcs11/pkcs11-spec/v3.1/pkcs11-spec-v3.1.html |
There was a problem hiding this comment.
Distribution terms are no longer noted here. I think it's still good to keep them here, right?
|
To be transparent about the maintenance situation: I don't have any access to HSMs. I'm not sure about @kislyuk? This means that any changes cannot currently be tested with real HSMs. |
|
@mathiasertl I can't promise anything ongoing, but I might be able to run the tests on Linux against AWS CloudHSMv2, if that would be of any use? Someone would have to note down exactly how to run the tests though! (I'd rather not try to work it out, get it wrong, and invalidate the results.) |
|
Any update on this pull request? I'd really love to see 0.8.0 being released and finally being able to use python 3.12 on my windows box. |
|
I guess this means it won't work with Python 3.13 also? |
|
I guess so. |
|
This PR has minor changes requested, if they are implemented I can merge this. Note however that I don't think I can upload releases to PyPI at the moment. @kislyuk do you have upload permissions by now? |
|
I do not. @danni can you please invite me to the python-pkcs11 package on PyPI? |
|
Yes I can do that. Same username? |
|
Yes, my PyPI username is identical to my GitHub one.
…On Mon, Dec 9, 2024 at 16:26 Danielle Madeley ***@***.***> wrote:
Yes I can do that. Same username?
—
Reply to this email directly, view it on GitHub
<#183 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGSOPNR2R54YTHQ6MG5J6L2EYYKNAVCNFSM6AAAAABPCOW5AOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRZHEYDOMZRGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
My username is mati: https://pypi.org/user/mati/ |
|
Any updates on when this might get merged in? |
|
Tested under 3.13 and it's ok. |
|
Hi! Are there any updates on this PR and if it will get merge? It adds support for the latest versions of Python, which is something that I really need. |
|
@mathiasertl have your blocking comments been addressed? |
| @@ -4,26 +4,31 @@ build-backend = "setuptools.build_meta" | |||
|
|
|||
| [project] | |||
| name = "python-pkcs11" | |||
| version = "0.7.0" | |||
| version = "0.8.0" | |||
There was a problem hiding this comment.
Please do not change the version manually, it will be changed automatically by the release process.
|
@mathiasertl - You can test via an HSM simulator. I typically use the Utimaco simulator which you can get for free you just have to make an account on their site. They have a traditional one called Cryptoserver (latest version is 6.1) and a post quantum one. The simulators work on Windows or Linux (with Linux you don't need to install anything, simply have JDK, copy files, and run script - supports both OpenJDK and Oracle Java framework. - https://utimaco.com/data-protection/simulators-and-trials. I would like this update as well, have a tool working in Linux but cannot make an easy deployable version to Windows... |
This is follow-up of the now closed PR #174. This new PR tries to update the PKCS#11 specification to the latest published version and brings compatibility to Python 3.12 on Windows.
The specific changes of this PR are:
The package has been tested on new virtual environments using Python 3.12 on Windows 11 with the asepkcs.dll (Athena Smartcard System ASE Card).