Skip to content

Commit dab71c0

Browse files
generatedunixname499836121facebook-github-bot
generatedunixname499836121
authored andcommitted
Unify cuBLASLt workspaces with cuBLAS workspaces (#145130)
Summary: As `cuBLAS` workspaces are already per-stream, there shouldn't be kernel execution overlap with `cuBLASLt` kernels. This PR reuses `cuBLAS` workspaces for `cuBLASLt` for the following benefits: + caching (`cuBLAS` workspaces were already cached, so now we get that for `cuBLASLt`) + "free" workspace size bump for `cuBLASLt` `cuBLASLt` workspace sizes were previously smaller than those for `cuBLAS` by default which potentially hurts performance, and we encountered difficulty in increasing the size due to downstream OOMs , see also #120925 + fixes behavior broken behavior with the memtracker; pytorch/pytorch#139442 attempted to handle peaky allocation behavior that broke memtracker equivalence tests but it didn't seem to fully work, here the cached/reused `cuBLAS` workspace seems to fix it + one environment variable to rule them all: `CUBLAS_WORKSPACE_CONFIG` applies directly to `cuBLASLt` without a confusing `CUBLASLT_WORKSPACE_SIZE` that users would also need to consider X-link: pytorch/pytorch#145130 Approved by: https://github.com/ngimel Reviewed By: atalman Differential Revision: D69257102 fbshipit-source-id: 4a2e6391fa899829758596ab2e2f4b16003e5197
1 parent 394bd88 commit dab71c0

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

userbenchmark/dynamo/dynamobench/common.py

+9
Original file line numberDiff line numberDiff line change
@@ -3563,6 +3563,15 @@ def run(runner, args, original_dir=None):
35633563
# some of the models do not support use_deterministic_algorithms
35643564
torch.use_deterministic_algorithms(True)
35653565
os.environ["CUBLAS_WORKSPACE_CONFIG"] = ":4096:8"
3566+
if args.only is not None and args.only in {
3567+
"DebertaForQuestionAnswering",
3568+
"RobertaForQuestionAnswering",
3569+
"nvidia_deeprecommender",
3570+
"volo_d1_224",
3571+
}:
3572+
# These seem unhappy with numerics of larger cuBLASLt workspace
3573+
# sizes following #145130 (due to enabling split-k?)
3574+
torch.backends.cuda.matmul.allow_fp16_reduced_precision_reduction = False
35663575
torch.backends.cudnn.deterministic = True
35673576
torch.backends.cudnn.allow_tf32 = False
35683577
torch.backends.cudnn.benchmark = False

0 commit comments

Comments
 (0)