Skip to content

Commit d6865ad

Browse files
Juha VuolleQt Cherry-pick Bot
Juha Vuolle
authored and
Qt Cherry-pick Bot
committed
Make Qt for Android compile without permissions -feature
The permissions were partially behind 'future' feature flag. Instead put permission code behind the actual 'permissions' feature flag, and require 'future' feature if permissions are enabled. Fixes: QTBUG-135617 Pick-to: 6.8 Change-Id: I573cca6a56c19bfc32a3f1df72a009cbe05ad2fb Reviewed-by: Assam Boudjelthia <[email protected]> (cherry picked from commit 965af85) Reviewed-by: Qt Cherry-pick Bot <[email protected]>
1 parent f6591e6 commit d6865ad

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

src/corelib/kernel/qjnihelpers.cpp

+2
Original file line numberDiff line numberDiff line change
@@ -349,8 +349,10 @@ jint QtAndroidPrivate::initJNI(JavaVM *vm, JNIEnv *env)
349349
return JNI_ERR;
350350
}
351351

352+
#if QT_CONFIG(permissions)
352353
if (!registerPermissionNatives(qJniEnv))
353354
return JNI_ERR;
355+
#endif
354356

355357
if (!registerNativeInterfaceNatives(qJniEnv))
356358
return JNI_ERR;

src/corelib/platform/android/qandroidextras.cpp

+4-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#include <QtCore/qtimer.h>
1212
#include <QtCore/qset.h>
1313

14-
#if QT_CONFIG(future)
14+
#if QT_CONFIG(permissions)
1515
#include <QtCore/qpromise.h>
1616
#endif
1717

@@ -1029,6 +1029,7 @@ void QAndroidActivityCallbackResultReceiver::registerCallback(
10291029
callbackMap.insert(receiverRequestCode, callbackFunc);
10301030
}
10311031

1032+
#if QT_CONFIG(permissions)
10321033
// Permissions API
10331034

10341035
QtAndroidPrivate::PermissionResult resultFromAndroid(jint value)
@@ -1190,6 +1191,8 @@ bool QtAndroidPrivate::registerPermissionNatives(QJniEnvironment &env)
11901191
});
11911192
}
11921193

1194+
#endif // QT_CONFIG(permissions)
1195+
11931196
QT_END_NAMESPACE
11941197

11951198
#include "moc_qandroidextras_p.cpp"

src/corelib/platform/android/qandroidextras_p.h

+2-1
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,8 @@ namespace QtAndroidPrivate
226226
const QAndroidServiceConnection &serviceConnection,
227227
BindFlags flags = BindFlag::None);
228228

229-
#if QT_CONFIG(future)
229+
#if QT_CONFIG(permissions)
230+
QT_REQUIRE_CONFIG(future);
230231
enum PermissionResult {
231232
Undetermined,
232233
Authorized,

0 commit comments

Comments
 (0)