-
Notifications
You must be signed in to change notification settings - Fork 161
RFC: Drop the "--unhandled-rejection" CLI flag and exit on unhandled rejections #790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
PR: #791 |
This is a bit problematic with #39 It doesn't track unhandled rejections, it tracks any rejections and exits on them I.e. this never prints and instead exits: Promise.reject().catch(() => {})
Promise.resolve().then(() => console.log('ok')) |
Do you have any suggestions? |
I would argue that not crashing the process on handled rejections is more important that reporting unhandled rejections.
Those don't crash the process on handled rejections, so the rationale behind this change doesn't hold? So perhaps this should be reverted until #39 is fixed. Side note: also Enabling unhandled rejection tracking by default seems perfectly reasonable, but only under the assumption that it works (and does not misfire for all rejections, including handled) |
Specific suggestion: revert, reopen, block on #39. |
I'll go through the entire discussion again because I remember there was something tricky about it. |
I think I got it fixed: #1038 |
Every other runtime does that by default. Node allows customizing the behavior but I guess that's for historical reasons, we could add the equivalent option too.
The text was updated successfully, but these errors were encountered: