Skip to content

disappear cells when i drag too fast and sometimes the app crash #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kelvinlemus opened this issue Jan 25, 2017 · 4 comments
Open

Comments

@kelvinlemus
Copy link

this happens at the end of the event when i drag too fast

and in other case the app crash but i can not replicate the error yet
flatten-children
null-is-not-an-object

i want to help, can you tell me how can i do that ?

@cyqresig
Copy link
Contributor

cyqresig commented Jan 26, 2017

Dear kelvinlemus.
Can u tell me more about ur environment sth like react-native version, device and so on?
And did it happen on device with release mode?

@kelvinlemus
Copy link
Author

i'm using:

  • react-native: 40
  • device emulator with android avd (android: 6.0 )
  • linux mint 18

this happens in development, the app is not pruduction ready

i think that _sortCells had not finished and _getTouchCell did not return cell or something like that

which part of code do you think i can look ?

and thanks for answering

@cyqresig
Copy link
Contributor

I think it is a bug with component's prop 'ref' in debug mode on android emulator.
It won't happen in release mode on device, so need not to fix the codes,

@kelvinlemus
Copy link
Author

kelvinlemus commented Jan 26, 2017

I'm using the example code and it works fine, but when i add more cells (36) the cells do not position correctly.
And i have tried this on physical device (android 5.1) and happens the same.

i have found the call of _sortDataSourceat the end of _onTouchEnd is not necessary, the view keep updated
https://github.com/react-native-component/react-native-smart-sortable-sudoku-grid/blob/master/SortableSudokuGrid.js#L319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants