-
Notifications
You must be signed in to change notification settings - Fork 88
Integrating with Expo #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Did you get any solution? |
I have used it successfully with Expo Plugins to generate the delegate. You can use this in your app config to give the proper permissions
|
@disco-panda awesome! mind sharing your config plugin ? |
Very nice. Share that bad boy? |
@disco-panda well done! Could you share the plugin? I don't mind cleaning up and helping PR this repo |
@ramezrafla forked the repo and created my own plugin. We dont have any contribution guide here, I don't know if I should request a PR. Note: I implemented the RNCallKeep in the AppDelegate too. This is the exact requirements of our app. https://github.com/jexodusmercado/react-native-voip-push-notification |
Holy mac-n-cheese. There isn't a number that would accurately represent the amount of people you are helping with this. You could request a PR here, but the main dev is in and out alot. |
@AlanGreyjoy Let me clean my code first then request a PR in a few days. I need sleep. The amount of trial and error to make it work locally and in the eas-build is too much. |
I know the pain... been developing a node-red plugin. Things like this make you worship whoever came up with HMR ha. |
I created the PR. Lets hope the main dev review this |
Dear @jexodusmercado -- well done! We worked in parallel. We used Notes:
|
Hey, sorry for the silly question but: How do I apply your approach? I create the plugin file, add the plugin to the config and make a build / prebuild? Or should I manually apply the modifications you outline in the AppDelegate.m modification? Or both? Thanks a lot for the help! |
Don't manually make the modifications, that would be overwritten when you next build. In your root folder (where you find package.json etc) create a file called voip.js, and paste the following into it (credit to @ramezrafla above):
Then in your app.config.js, add the following:
And the following:
Then just build normally. A word of warning, this plugin assumes your VoIP notification contains a data dictionary with the properties handle, callerName and uuid. Without those, your app will crash when you receive a notification. If you want to change that, find them in voip.js and amend as needed. Example push notification payload:
Final point - I changed the video settings to 'YES' - as this allows a user to automatically go to your app even if their phone was locked prior to receiving the call |
Has anybody managed to get an Expo Module/Config Plugin working for this lib ?
This is the only lib under
react-native-webrtc/
organization that doesn't provide thisThe text was updated successfully, but these errors were encountered: