From 18d5a0005d7d85d5e61a982ea6459db67565df45 Mon Sep 17 00:00:00 2001 From: Hongli Lai Date: Thu, 25 Mar 2021 14:33:23 +0100 Subject: [PATCH] fix(language-server-ruby): pass valid filenames to RuboCop and Reek Without extraneous single quotes. Closes #719. --- packages/language-server-ruby/src/linters/Reek.ts | 2 +- packages/language-server-ruby/src/linters/RuboCop.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/language-server-ruby/src/linters/Reek.ts b/packages/language-server-ruby/src/linters/Reek.ts index a92348ef3..727aa26ea 100644 --- a/packages/language-server-ruby/src/linters/Reek.ts +++ b/packages/language-server-ruby/src/linters/Reek.ts @@ -27,7 +27,7 @@ export default class Reek extends BaseLinter { get args(): string[] { const documentPath = URI.parse(this.document.uri); - return ['-f', 'json', '--stdin-filename', `'${documentPath.fsPath}'`]; + return ['-f', 'json', '--stdin-filename', documentPath.fsPath]; } protected processResults(data): Diagnostic[] { diff --git a/packages/language-server-ruby/src/linters/RuboCop.ts b/packages/language-server-ruby/src/linters/RuboCop.ts index 5a49c05ec..eb2f0d7d1 100644 --- a/packages/language-server-ruby/src/linters/RuboCop.ts +++ b/packages/language-server-ruby/src/linters/RuboCop.ts @@ -58,7 +58,7 @@ export default class RuboCop extends BaseLinter { get args(): string[] { const documentPath = URI.parse(this.document.uri); - let args = ['-s', `'${documentPath.fsPath}'`, '-f', 'json']; + let args = ['-s', documentPath.fsPath, '-f', 'json']; if (this.lintConfig.rails) args.push('-R'); if (this.lintConfig.forceExclusion) args.push('--force-exclusion'); if (this.lintConfig.lint) args.push('-l');