Skip to content
This repository was archived by the owner on Dec 4, 2023. It is now read-only.

Release libv8 compiled with muslc support in Github Releases #270

Closed
deepj opened this issue Oct 27, 2018 · 9 comments
Closed

Release libv8 compiled with muslc support in Github Releases #270

deepj opened this issue Oct 27, 2018 · 9 comments

Comments

@deepj
Copy link

deepj commented Oct 27, 2018

Hello,
since rubygems can't recognize used glibc or muslc support so it's not possible to release a gem compiled with muslc to rubygems.org. But it's still to possible to release it here in Releases and download it from here and use it manually, e.g. this way:

gem list | grep libv8 || curl -O https://github.com/cowboyd/libv8/releases/download/v6.7.288.46.1/libv8-6.7.288.46.1-x86_64-linux-muslc.gem && gem install libv8-6.7.288.46.1-x86_64-linux-muslc.gem && rm libv8-6.7.288.46.1-x86_64-linux-muslc.gem

It's not easy to set and compile libv8 gem on Alpine Linux. This would help the folks who use Alpine Linux based Docker images. Yes, this is a workaround, but it's some quite easy solution for some of us.

@ignisf
Copy link
Collaborator

ignisf commented Oct 28, 2018

Hey, that's an interesting idea!

@volkanunsal
Copy link

This would be great to have. I've been struggling to install libv8 on Alpine for a few days now.

@ignisf
Copy link
Collaborator

ignisf commented Nov 19, 2018

Hello,

Sorry it took a while to get back to you, but while this might work as a workaround for one major issue to getting libv8 on Alpine, the current blocker is #259. I'd gladly publish a binary linked against musl if I could build one at all...

@deepj
Copy link
Author

deepj commented Nov 22, 2018

@ignisf yeah, it's just a workaround. But I haven't noticed any issue in rubygems/bundler to reflect this issue (gem's muslc support). Maybe worth to create and start a discussion on this topic? I just don't know how to describe the problem well, so I would leave it on someone more knowledgeable/

@lloeki
Copy link
Contributor

lloeki commented Jan 10, 2020

Hey @ignisf, we (Sqreen) maintain and push libv8-alpine and libv8-solaris gems, which we built by fetching source outside of the target platforms, then building libv8_monolith.a (with some build system patches). It's hackish, and currently stuck at 6.8.

To achieve a sustainable solution, we're tackling this together with upstream, and currently aiming at having libv8_monolith.a automatically built from NodeJS's v8, and published upstream for all NodeJS supported platforms (which include Alpine and SmartOS, thus Solaris), starting with libv8 7.4. IIUC this strategy would sidestep #259 entirely as you'd be able to fetch the static libs and use them right away for packaging as a gem.

Does that sound interesting to you?

@nightpool
Copy link
Collaborator

@lloeki This does sound interesting! Can we create a new tracking issue for this? What's the next step to push this forward on Node's side? Are there any differences between Node's build configuration and ours that we'd have to sort out? Would we run into any incompatibilities with those who wanted to use their own version of v8?

@lloeki
Copy link
Contributor

lloeki commented Aug 11, 2020

Can we create a new tracking issue for this?

I forgot how many issues might be tied to this. Let me create a new issue on this repo to track that overall.

@lloeki
Copy link
Contributor

lloeki commented Aug 11, 2020

Opened #304 as suggested!

@lloeki
Copy link
Contributor

lloeki commented Dec 4, 2023

Closing as ruby gems now allows that, plus this issue is completely sidestepped in libv8-node, which does have linux(-gnu) and linux-musl builds.

@lloeki lloeki closed this as completed Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants