Skip to content

Commit 30d65e6

Browse files
committed
Deprecate -sMAYBE_WASM2JS settings
Users of this settings will now see: ``` emcc: warning: MAYBE_WASM2JS is deprecated (no known users). Please open a bug if you have a continuing need for this setting [-Wdeprecated] ``` See emscripten-core#23969
1 parent a5af114 commit 30d65e6

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

test/test_core.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -8388,7 +8388,7 @@ def test_maybe_wasm2js(self):
83888388
self.skipTest('redundant to test wasm2js in wasm2js* mode')
83898389
self.set_setting('MAYBE_WASM2JS')
83908390
# see that running as wasm works
8391-
self.do_core_test('test_hello_world.c')
8391+
self.do_core_test('test_hello_world.c', emcc_args=['-Wno-deprecated'])
83928392
# run wasm2js, bundle the code, and use the wasm2js path
83938393
cmd = [PYTHON, path_from_root('tools/maybe_wasm2js.py'), 'test_hello_world.js', 'test_hello_world.wasm']
83948394
if self.is_optimizing():

tools/settings.py

+1
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,7 @@
126126
'LEGALIZE_JS_FFI': 'to disable JS type legalization use `-sWASM_BIGINT` or `-sSTANDALONE_WASM`',
127127
'ASYNCIFY_EXPORTS': 'please use JSPI_EXPORTS instead',
128128
'EMULATE_FUNCTION_POINTER_CASTS': 'lack of usage',
129+
'MAYBE_WASM2JS': 'lack of usage',
129130
}
130131

131132
# Settings that don't need to be externalized when serializing to json because they

0 commit comments

Comments
 (0)