-
Notifications
You must be signed in to change notification settings - Fork 38
Add Organization id into OIDC JWT token claims #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think that |
Hi @colemickens, Thanks again for pushing this forward. A couple of thoughts on the proposed
In general, we aim to keep tokens lean and avoid adding claims that duplicate existing data. Do you have a specific use case in mind where these additional claims would provide value that the current ones cannot? |
@dexyk Thanks for the response! For the org name, that's fine, but not 100% ideal. For the
Without this, we will have to do something like use Please note, GitHub and GitLab both offer both forms of these claims - their human readable (and mutable) names, as well as their immutable ids. Additionally, I'm looking forward to BuildKite and they have quite an interesting offer in contrast, providing all of the claims I could hope for, then some, then with customization ability on top: https://buildkite.com/docs/agent/v3/cli-oidc |
Is your improvement proposal related to a problem? Please describe.
Currently, in the OIDC token generation it would be good to include an immutable claim field for the organization that is not its name.
Describe the solution you'd like
Include the organization Id in the default JWT Claims and maybe in the SUB claim composition.
As described here: https://docs.semaphoreci.com/reference/openid
Describe alternatives you've considered
No response
Additional context
The JWT implementation can be found here: https://github.com/semaphoreio/semaphore/blob/main/secrethub/lib/secrethub/open_id_connect/jwt.ex
The text was updated successfully, but these errors were encountered: