fix module resolution when external pkg has module with same name (#43)

Author: ggilmore

langserver/workspace.py

@@ -357,7 +357,7 @@ def find_internal_module(self, name: str, qualified_name: str, dirs: List[str]):
             elif self.folder_exists(os.path.join(parent, name)):
                 # there's a folder at this level that implements a namespace package with the name we're looking for
                 module_paths.append(os.path.join(parent, name))
-            elif os.path.basename(parent) == name:
+            elif self.folder_exists(parent) and os.path.basename(parent) == name:
                 # we're already in a namespace package with the name we're looking for
                 module_paths.append(parent)
         if not module_paths:

test/repos/dep_pkg_module_same_name/Pipfile

@@ -0,0 +1,3 @@
+[packages]
+
+libfarhan = "==0.6"

test/repos/dep_pkg_module_same_name/Pipfile.lock

@@ -0,0 +1,22 @@
+{
+    "packages": [
+      {
+        "package_name": "django",
+        "version": ">0.5.0",
+        "source" : {
+          "name": "pypi",
+          "verify_ssl": "True",
+          "url": "https://pypi.python.org/simple"
+        }
+      },
+      {
+        "package_name": "eventlet",
+        "version": ">=0.16.1,<0.19.0",
+        "source" : {
+          "name": "pypi",
+          "verify_ssl": "True",
+          "url": "https://pypi.python.org/simple"
+        }
+      }
+    ]
+}

test/repos/dep_pkg_module_same_name/pyconfig.json

@@ -0,0 +1,3 @@
+from libfarhan import libfarhan.testfunc
+
+print(libfarhan.testfunc())

test/repos/dep_pkg_module_same_name/test.py

@@ -0,0 +1,25 @@
+from .harness import Harness
+import uuid
+import pytest
+
+@pytest.fixture()
+def workspace():
+    workspace = Harness("repos/dep_pkg_module_same_name")
+    workspace.initialize("repos/dep_pkg_module_same_name" + str(uuid.uuid4()))
+    yield workspace
+    workspace.exit()
+
+class TestExtPkgHasModuleWithSameName:
+    def test_hover_pkg_module_same_name(self, workspace):
+        uri = "file:///test.py"
+        line, col = 2, 18
+        result = workspace.hover(uri, line, col)
+        assert result == {
+            'contents': [
+                {
+                    'language': 'python', 
+                    'value': 'def testfunc()'
+                }, 
+                'this is version 0.6'
+            ]
+        }