Skip to content

Commit 17fa5be

Browse files
committed
refactor: remove ident altogether
We're not supposed to escape the table name since it's supposed to be possibly fully qualified with the schema name.
1 parent 66e148c commit 17fa5be

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

src/lib/PostgresMetaPublications.ts

+2-5
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ export default class PostgresMetaPublications {
6868
} else if (tables.length === 0) {
6969
tableClause = ''
7070
} else {
71-
tableClause = `FOR TABLE ${tables.map(ident).join(',').replace(/"/g, '')}`
71+
tableClause = `FOR TABLE ${tables.join(',')}`
7272
}
7373

7474
let publishOps = []
@@ -138,10 +138,7 @@ CREATE PUBLICATION ${ident(name)} ${tableClause}
138138
} else if (old!.tables === null) {
139139
throw new Error('Tables cannot be added to or dropped from FOR ALL TABLES publications')
140140
} else if (tables.length > 0) {
141-
tableSql = `ALTER PUBLICATION ${ident(old!.name)} SET TABLE ${tables
142-
.map(ident)
143-
.join(',')
144-
.replace(/"/g, '')};`
141+
tableSql = `ALTER PUBLICATION ${ident(old!.name)} SET TABLE ${tables.join(',')};`
145142
} else if (old!.tables.length === 0) {
146143
tableSql = ''
147144
} else {

0 commit comments

Comments
 (0)