Skip to content

Commit ddbe2ab

Browse files
committed
Fix tests
1 parent 7ea0692 commit ddbe2ab

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

wfb_ng/tests/test_tuntap.py

+7-3
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,12 @@
33

44
import os
55
import time
6+
from twisted import version as twisted_version
67
from twisted.python import log
78
from twisted.trial import unittest
89
from twisted.internet import reactor, defer
910
from twisted.internet.utils import getProcessOutputAndValue
11+
from incremental import Version
1012
from ..tuntap import TUNTAPTransport, TUNTAPProtocol
1113
from ..common import df_sleep
1214

@@ -20,11 +22,13 @@
2022
"""
2123

2224
docker_arch = os.environ.get('DOCKER_ARCH')
23-
bad_qemu_arch = ("mips64le.mips64le.MIPS64R2-generic", "s390x.s390x.max", "ppc64le.ppc64le.power8")
25+
bad_qemu_arch = ("mips64le", "s390x", "ppc64le")
2426

2527
class TUNTAPTestCase(unittest.TestCase):
26-
if os.geteuid() != 0 or not os.path.exists('/dev/net/tun') or docker_arch in bad_qemu_arch:
27-
skip = "Root permission is required to test tunnel"
28+
if os.geteuid() != 0 or not os.path.exists('/dev/net/tun') \
29+
or docker_arch in bad_qemu_arch \
30+
or twisted_version < Version("Twisted", 19, 7, 0):
31+
skip = "Root requires or system is incompatible"
2832

2933
def setUp(self):
3034
self.p1 = TUNTAPProtocol(mtu=1400)

0 commit comments

Comments
 (0)