Frontend: use preferred path spellings for paths

Convert paths to the preferred spelling before passing it to the
SourceManager to ensure that we have the canonical spelling. This is
important as a path with a non-canonical path separator would otherwise
fail to be looked up in the source manager buffer.

Author: compnerd

lib/Frontend/DiagnosticVerifier.cpp

@@ -1289,15 +1289,17 @@ bool DiagnosticVerifier::finishProcessing() {
 
   SmallVector<unsigned, 4> additionalBufferIDs;
   for (auto path : AdditionalFilePaths) {
-    auto bufferID = SM.getIDForBufferIdentifier(path);
+    llvm::SmallString<261> buffer{path};
+    llvm::sys::path::make_preferred(buffer);
+    auto bufferID = SM.getIDForBufferIdentifier(buffer);
     if (!bufferID) {
       // Still need to scan this file for expectations.
-      auto result = SM.getFileSystem()->getBufferForFile(path);
+      auto result = SM.getFileSystem()->getBufferForFile(buffer);
       if (!result) {
         auto message = SM.GetMessage(
            SourceLoc(), llvm::SourceMgr::DiagKind::DK_Error,
            llvm::Twine("unable to open file in '-verify-additional-file ") +
-           path + "': " + result.getError().message(), {}, {});
+           buffer + "': " + result.getError().message(), {}, {});
         printDiagnostic(message);
         Result.HadError |= true;
         continue;

test/ModuleInterface/BadStdlib.swiftinterface

@@ -14,6 +14,3 @@
 import ClangMod
 
 public func useHasPointer(_: HasPointer)
-
-// FIXME: https://github.com/apple/swift/issues/56844
-// UNSUPPORTED: OS=windows-msvc