Merge pull request #81058 from nate-chandler/rdar149782365

[SILGen] Make eagerMove class init's self lexical.

Author: nate-chandler

lib/SILGen/SILGenConstructor.cpp

@@ -1114,8 +1114,15 @@ void SILGenFunction::emitClassConstructorInitializer(ConstructorDecl *ctor) {
                                    /*ignored parameters*/ 1);
 
   SILType selfTy = getLoweredLoadableType(selfDecl->getTypeInContext());
-  ManagedValue selfArg = B.createInputFunctionArgument(selfTy, selfDecl);
-  
+  // Force a lexical lifetime for the self argument of an eagerMove class' init
+  // to ensure that the body of its deinit always runs after the body of that
+  // init.
+  LifetimeAnnotation annotation = selfTy.getLifetime(F).isEagerMove()
+                                      ? LifetimeAnnotation::Lexical
+                                      : LifetimeAnnotation::None;
+  ManagedValue selfArg = B.createInputFunctionArgument(
+      selfTy, selfDecl, /*isNoImplicitCopy=*/false, annotation);
+
   // is this a designated initializer for a distributed actor?
   const bool isDesignatedDistActorInit =
     selfClassDecl->isDistributedActor() && !isDelegating;

test/Interpreter/rdar149782365.swift

@@ -0,0 +1,31 @@
+// RUN: %target-run-simple-swift | %FileCheck %s
+
+@_silgen_name("start")
+func start() {
+  print("init C")
+}
+@_silgen_name("barrier")
+func barrier() {
+	print("nothing uses C anymore")
+}
+@_silgen_name("end")
+func end() {
+  print("deinit C")
+}
+
+@_eagerMove class C {
+	init() { start() }
+	deinit { end() }
+}
+
+@_silgen_name("doit")
+public func main() {
+	C()
+  barrier()
+}
+
+main()
+
+// CHECK: init C
+// CHECK: deinit C
+// CHECK: nothing uses C anymore