Skip to content

UUI-BUTTON active font color is not included in the Dark Theme #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
readingdancer opened this issue Feb 10, 2025 · 1 comment
Open
Labels
bug Something isn't working community/up-for-grabs good first issue Good for newcomers

Comments

@readingdancer
Copy link

Which exact UI Library version are you using? For example: 1.0.1 - don't just write v1.

Whichever version is bundled with Umbraco 15.2.0

Bug summary

The number on the active page number is not visible in dark mode.

I wasn't sure if the theme was part of the UUI library or the main Umbraco CMS project?

Specifics

This is what you see in dark mode:

Image

This is the issue, the --uui-button-contrast variable has not been setup in the dark theme.

Image

Steps to reproduce

Within Umbraco, log in and switch to "dark" mode.

Go to any page that has paging at the bottom (for example, the log viewer), you will see the active item is a blue button, but there appears to be no writing as the font color has not been set.

See the screen shots above.

Expected result / actual result

I'd expect the variable to be set and to probably have a white font color, or something similar so the user can see the font :)

@readingdancer readingdancer added bug Something isn't working needs triage This issue has not been tested by a team member yet labels Feb 10, 2025
@iOvergaard
Copy link
Contributor

Thanks for the report. The --uui-button-contrast does not need to be set, as that falls back to --color-standalone, which then again falls back to --uui-color-default-standalone. That color is already set to a blue-ish hue in the dark theme to match the non-selected state of buttons. Unfortunately, if we set it to something else, then we change all buttons.

That means that the real underlying problem is that the uui-button component does not offer any alternative color when it is active/selected, therefore we cannot add a corresponding color on the dark theme in the CMS. It will have to be solved here in the UI library first and then added to the dark theme in the CMS.

@iOvergaard iOvergaard added good first issue Good for newcomers community/up-for-grabs and removed needs triage This issue has not been tested by a team member yet labels Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community/up-for-grabs good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants