Make forms and few other UI responsive #174
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzulfikar
changed the title
wzulfikar
commented
Apr 22, 2025
Comment on lines
+714
to
+715
| <div className={"prose prose-sm prose-neutral space-y-4 break-words p-4 w-full"}> | ||
| <div className={"w-full lg:w-[600px]"}> |
There was a problem hiding this comment.
Only set the fixed width for large screen so the editor content doesn't overflow in small screen
Before:
After:
wzulfikar
commented
Apr 22, 2025
| @@ -739,7 +739,7 @@ export default function Editor({ value, onChange, mode, modeSwitcher }: Markdown | |||
| </> | |||
| ) : ( | |||
| <> | |||
| <div className={"mb-3 grid gap-3 md:grid-cols-1"}> | |||
| <div className={"mb-3 sm:grid sm:gap-3 md:grid-cols-1"}> | |||
wzulfikar
commented
Apr 22, 2025
| @@ -415,7 +415,7 @@ export default function Index() { | |||
| return router.push("/actions"); | |||
| }} | |||
| className={ | |||
| "flex w-full justify-center rounded border border-neutral-300 bg-white px-6 py-2 text-base font-medium text-neutral-800 focus:outline-none focus:ring-2 focus:ring-neutral-800 focus:ring-offset-2 sm:mt-0 sm:w-auto sm:text-sm" | |||
| "flex w-fit justify-center rounded border border-neutral-300 bg-white px-6 py-2 text-base font-medium text-neutral-800 focus:outline-none focus:ring-2 focus:ring-neutral-800 focus:ring-offset-2 sm:mt-0 sm:w-auto sm:text-sm" | |||
There was a problem hiding this comment.
Cancel button can go too wide in certain screen size making it looks weird. I applied the same treatment for other cancel buttons.
Before:
After:
wzulfikar
commented
Apr 22, 2025
There was a problem hiding this comment.
All forms will get the same treatment to make it responsive:
- Added
space-y-6 sm:space-y-0to add vertical space in small screen but still use gap in other screen (viasm:gap-6 - Added
sm:to grid classes so the UI doesn't overflow
Before:
After:
wzulfikar
commented
Apr 22, 2025
There was a problem hiding this comment.
Add truncate to prevent overflow
Before:
After:
wzulfikar
commented
Apr 22, 2025
| @@ -64,7 +64,7 @@ export default function Index() { | |||
| {actions ? ( | |||
| actions.length > 0 ? ( | |||
| <> | |||
| <div className={"grid grid-cols-1 gap-6 sm:grid-cols-2"}> | |||
| <div className={"grid grid-cols-1 gap-6 lg:grid-cols-2"}> | |||
There was a problem hiding this comment.
Action and Template cards are squeezed in medium screens. Changed from sm to lg to fix it.
Before:
After:
|
@driaug pls take a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #172