feat: INSERT...SELECT syntax implementation.

Author: Javakky-pxv

src/Parser/InsertParser.php

@@ -1,9 +1,10 @@
 <?php
+
 namespace Vimeo\MysqlEngine\Parser;
 
 use Vimeo\MysqlEngine\Query\Expression\Expression;
-use Vimeo\MysqlEngine\TokenType;
 use Vimeo\MysqlEngine\Query\InsertQuery;
+use Vimeo\MysqlEngine\TokenType;
 
 final class InsertParser
 {
@@ -130,6 +131,12 @@ public function parse()
                             list($this->pointer, $query->setClause) = $p->parse();
                             break;
 
+                        case 'SELECT':
+                            $select_parser = new SelectParser($this->pointer, $this->tokens, $this->sql);
+                            $query->selectQuery = $select_parser->parse();
+                            $this->pointer = $select_parser->getPointer();
+                            break;
+
                         default:
                             throw new ParserException("Unexpected clause {$token->value}");
                     }
@@ -168,7 +175,7 @@ public function parse()
                     } else {
                         if ($this->currentClause === 'COLUMN_LIST' && $needs_comma && $token->value === ')') {
                             $needs_comma = false;
-                            if (($this->tokens[$this->pointer + 1]->value ?? null) !== 'VALUES') {
+                            if (!in_array($this->tokens[$this->pointer + 1]->value ?? null, ['VALUES', 'SELECT'])) {
                                 throw new ParserException("Expected VALUES after insert column list");
                             }
                             break;
@@ -203,7 +210,7 @@ public function parse()
 
             $this->pointer++;
         }
-        if ((!$query->insertColumns || !$query->values) && !$query->setClause) {
+        if ((!$query->insertColumns || !$query->values) && !$query->setClause && !$query->selectQuery) {
             throw new ParserException("Missing values to insert");
         }
         return $query;

src/Parser/SelectParser.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace Vimeo\MysqlEngine\Parser;
 
 use Vimeo\MysqlEngine\Query\Expression\ColumnExpression;
@@ -48,6 +49,11 @@ public function __construct(int $pointer, array $tokens, string $sql)
         $this->sql = $sql;
     }
 
+    public function getPointer(): int
+    {
+        return $this->pointer;
+    }
+
     public function parse() : SelectQuery
     {
         // if the first part of this query is nested, we should be able to unwrap it safely

src/Processor/InsertProcessor.php

@@ -1,8 +1,8 @@
 <?php
+
 namespace Vimeo\MysqlEngine\Processor;
 
 use Vimeo\MysqlEngine\DataIntegrity;
-use Vimeo\MysqlEngine\Query\Expression\ColumnExpression;
 use Vimeo\MysqlEngine\Query\InsertQuery;
 use Vimeo\MysqlEngine\Schema\Column\IntegerColumn;
 
@@ -108,6 +108,29 @@ public static function process(
             );
         }
 
+        if ($stmt->selectQuery) {
+            $selectResult = SelectProcessor::process(
+                $conn,
+                $scope,
+                $stmt->selectQuery
+            )->rows;
+
+            $row = [];
+            foreach ($selectResult as $value) {
+                foreach ($stmt->selectQuery->selectExpressions as $index => $expr) {
+                    if (key_exists($index, $stmt->insertColumns)
+                        && (is_string($value[$expr->name]) || is_int($value[$expr->name]))) {
+                        $row[$stmt->insertColumns[$index]] = $value[$expr->name];
+                    }
+                }
+            }
+
+            $table[] = $row;
+
+            $conn->getServer()->saveTable($database, $table_name, $table);
+            return count($selectResult);
+        }
+
         return $rows_affected;
     }
 }

src/Query/InsertQuery.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace Vimeo\MysqlEngine\Query;
 
 use Vimeo\MysqlEngine\Query\Expression\BinaryOperatorExpression;
@@ -41,6 +42,9 @@ final class InsertQuery
      */
     public $setClause = null;
 
+    /** @var SelectQuery|null $selectExpression */
+    public $selectQuery = null;
+
     public function __construct(string $table, string $sql, bool $ignoreDupes)
     {
         $this->table = $table;

tests/EndToEndTest.php

@@ -1,6 +1,7 @@
 <?php
 namespace Vimeo\MysqlEngine\Tests;
 
+use PDO;
 use PDOException;
 
 class EndToEndTest extends \PHPUnit\Framework\TestCase
@@ -911,6 +912,37 @@ public function testInsertWithNullAndEmpty()
         );
     }
 
+    public function testInsertWithSelect(): void
+    {
+        $pdo = self::getConnectionToFullDB(false);
+
+        $query = $pdo->prepare(
+            "INSERT INTO `video_game_characters`
+                (`id`, `name`, `type`, `profession`, `console`, `is_alive`, `powerups`, `skills`, `created_on`)
+                SELECT
+                    19+`id`, 'wario','villain','plumber','nes','1','3','{\"magic\":0, \"speed\":0, \"strength\":0, \"weapons\":0}', NOW(), 
+                FROM `video_game_characters`"
+        );
+
+        $query->execute();
+
+        $query = $pdo->prepare(
+            'SELECT `id`, `name`
+            FROM `video_game_characters`
+            ORDER BY `id` DESC
+            LIMIT 1'
+        );
+
+        $query->execute();
+
+        $this->assertSame(
+            [
+                ['id' => 35, 'name' => 'wario'],
+            ],
+            $query->fetchAll(PDO::FETCH_ASSOC)
+        );
+    }
+
     public function testOrderBySecondDimensionAliased()
     {
         $pdo = self::getConnectionToFullDB(false);