File tree 2 files changed +5
-6
lines changed
2 files changed +5
-6
lines changed Original file line number Diff line number Diff line change @@ -40,6 +40,4 @@ public function saveMetrics(Wiki $wiki): void
40
40
41
41
\Log::info ("New metric recorded for WikiMetrics ID {$ wiki ->id }" );
42
42
}
43
-
44
43
}
45
-
Original file line number Diff line number Diff line change @@ -26,18 +26,19 @@ class WikiDailyMetrics extends Model
26
26
];
27
27
28
28
// list of properties which are actual wiki metrics
29
- static public $ metricNames = [
29
+ public static $ metricNames = [
30
30
'pages ' ,
31
31
'is_deleted ' ,
32
32
];
33
33
34
- public function areMetricsEqual (WikiDailyMetrics $ wikiDailyMetrics ) {
35
-
34
+ public function areMetricsEqual (WikiDailyMetrics $ wikiDailyMetrics ): bool
35
+ {
36
36
foreach (self ::$ metricNames as $ field ) {
37
- if ($ this ->$ field !== $ wikiDailyMetrics ->$ field ) {
37
+ if ($ this ->$ field != $ wikiDailyMetrics ->$ field ) {
38
38
return false ;
39
39
}
40
40
}
41
+
41
42
return true ;
42
43
}
43
44
}
You can’t perform that action at this time.
0 commit comments