From 14ce2197255d46a8a3198e23324681bb956bfabc Mon Sep 17 00:00:00 2001 From: "Daniel D. Beck" Date: Wed, 23 Apr 2025 15:40:35 +0200 Subject: [PATCH] Allow ovlerapping BCD keys --- features/text-wrap-pretty.yml | 3 +++ features/text-wrap-pretty.yml.dist | 19 ++++++++++++++++--- index.ts | 9 +-------- 3 files changed, 20 insertions(+), 11 deletions(-) diff --git a/features/text-wrap-pretty.yml b/features/text-wrap-pretty.yml index 69e68d0f19d..309b2a1f191 100644 --- a/features/text-wrap-pretty.yml +++ b/features/text-wrap-pretty.yml @@ -2,3 +2,6 @@ name: "text-wrap: pretty" description: "The `text-wrap: pretty` CSS declaration prioritizes better layout over speed when text is broken into multiple lines." spec: https://drafts.csswg.org/css-text-4/#valdef-text-wrap-style-pretty group: text-wrap +compat_features: + - css.properties.text-wrap.pretty + - css.properties.text-wrap-style.pretty diff --git a/features/text-wrap-pretty.yml.dist b/features/text-wrap-pretty.yml.dist index 887837c8b8f..32937fde0df 100644 --- a/features/text-wrap-pretty.yml.dist +++ b/features/text-wrap-pretty.yml.dist @@ -4,8 +4,21 @@ status: baseline: false support: - chrome: "117" - chrome_android: "117" - edge: "117" + chrome: "130" + chrome_android: "130" + edge: "130" compat_features: + # baseline: false + # support: + # chrome: "117" + # chrome_android: "117" + # edge: "117" - css.properties.text-wrap.pretty + + # ⬇️ Same status as overall feature ⬇️ + # baseline: false + # support: + # chrome: "130" + # chrome_android: "130" + # edge: "130" + - css.properties.text-wrap-style.pretty diff --git a/index.ts b/index.ts index d7df26716bf..61749583ce5 100644 --- a/index.ts +++ b/index.ts @@ -167,15 +167,8 @@ for (const [key, data] of yamlEntries('features')) { // no effect on what web-features users see. data.compat_features.sort(); - // Check that no BCD key is used twice until the meaning is made clear in - // https://github.com/web-platform-dx/web-features/issues/1173. for (const bcdKey of data.compat_features) { - const otherKey = bcdToFeatureId.get(bcdKey); - if (otherKey) { - throw new Error(`BCD key ${bcdKey} is used in both ${otherKey} and ${key}, which creates ambiguity for some consumers. Please see https://github.com/web-platform-dx/web-features/issues/1173 and help us find a good solution to allow this.`); - } else { - bcdToFeatureId.set(bcdKey, key); - } + bcdToFeatureId.set(bcdKey, key); } }