Skip to content

Update deprecations rulesets #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
edg2s opened this issue Sep 26, 2019 · 1 comment · Fixed by #120
Closed

Update deprecations rulesets #117

edg2s opened this issue Sep 26, 2019 · 1 comment · Fixed by #120

Comments

@edg2s
Copy link
Member

edg2s commented Sep 26, 2019

jQuery deprecations are poorly documented, in various places you get different answers as to when a rule was deprecated. Is it when core is updated, or when jquery migrate is updated? And the docs at api.jquery.com are missing a lot of deprecations (e.g. all of 3.2).

Going by the release notes we are missing a few things:
3.3: https://blog.jquery.com/2018/01/19/jquery-3-3-0-a-fragrant-bouquet-of-deprecations-and-is-that-a-new-feature/
3.2: https://blog.jquery.com/2017/03/16/jquery-3-2-0-is-out/

Other info:
Task about 3.2/3.3 deprecations: jquery/api.jquery.com#972

@stof
Copy link
Contributor

stof commented Sep 26, 2019

I suggest basing that on when core is updated, rather than when jquery migrate catches up.

edg2s added a commit that referenced this issue Sep 26, 2019
Added to 3.3:
* `no-event-shorthand`
* `no-is-numeric`
* `no-now`
* `no-proxy`
* `no-type`

Create a 3.2 ruleset:
* `no-hold-ready`
* `no-is-array`
* `no-node-name`

Fixes #117
jdforrester pushed a commit that referenced this issue Sep 26, 2019
Added to 3.3:
* `no-event-shorthand`
* `no-is-numeric`
* `no-now`
* `no-proxy`
* `no-type`

Create a 3.2 ruleset:
* `no-hold-ready`
* `no-is-array`
* `no-node-name`

Fixes #117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants