Add LIBXML_NOBLANKS option

itamargiv · lucaswerkmeister · commit fa76a8bd09ad · 2020-10-08T16:43:24.000+02:00
diff --git a/src/Component.php b/src/Component.php
@@ -72,7 +72,9 @@ private function parseHtml( $html ) {
 		$document = new DOMDocument( '1.0', 'UTF-8' );
 
 		// Ensure $html is treated as UTF-8, see https://stackoverflow.com/a/8218649
-		if ( !$document->loadHTML( '<?xml encoding="utf-8" ?>' . $html ) ) {
+		// LIBXML_NOBLANKS Constant excludes "ghost nodes" to avoid violating
+		// vue's single root node constraint
+		if ( !$document->loadHTML( '<?xml encoding="utf-8" ?>' . $html, LIBXML_NOBLANKS ) ) {
 			//TODO Test failure
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,9 @@ private function parseHtml( $html ) {`
`72`	`72`	`$document = new DOMDocument( '1.0', 'UTF-8' );`
`73`	`73`
`74`	`74`	`// Ensure $html is treated as UTF-8, see https://stackoverflow.com/a/8218649`
`75`		`- if ( !$document->loadHTML( '<?xml encoding="utf-8" ?>' . $html ) ) {`
	`75`	`+ // LIBXML_NOBLANKS Constant excludes "ghost nodes" to avoid violating`
	`76`	`+ // vue's single root node constraint`
	`77`	`+ if ( !$document->loadHTML( '<?xml encoding="utf-8" ?>' . $html, LIBXML_NOBLANKS ) ) {`
`76`	`78`	`//TODO Test failure`
`77`	`79`	`}`
`78`	`80`