-
Notifications
You must be signed in to change notification settings - Fork 24
Remove unused parameters from setState #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Oh, nice catch! It seems so. |
Hi Luke, I saw your video and it's amazing. Let me know if you want to be an official contributor of this repo (with write access), or chat with me on telegram, whatsapp? I'd be happy to help you and improve W at the same time. |
Glad you like the video. Sure, I'd love to be a contributor! I'm also on Discord and WhatsApp. |
I added you :) |
As far as I can tell, the
setState
function (https://github.com/xem/W/blob/gh-pages/w.js#L131) only uses thestate
,type
, andtexture
parameters, and does not usei, normal = [], A, B, C, Ai, Bi, Ci, AB, BC
.@xem -- Can these be safely removed?
The text was updated successfully, but these errors were encountered: