test [nfc]: Switch from store.handleEvent to store.addMessage(s)

This leaves some tests that handle MessageEvent untouched,
as they conceptually aren't just setting up the store, and the helper
adds a layer of indirection (or they simply don't have access to a
PerAccountStore).

Author: PIG208

test/model/message_list_test.dart

@@ -367,8 +367,7 @@ void main() {
       List.generate(30, (i) => eg.streamMessage(stream: stream)));
 
     check(model).messages.length.equals(30);
-    await store.handleEvent(MessageEvent(id: 0,
-      message: eg.streamMessage(stream: stream)));
+    await store.addMessage(eg.streamMessage(stream: stream));
     checkNotifiedOnce();
     check(model).messages.length.equals(31);
   });
@@ -381,17 +380,15 @@ void main() {
 
     check(model).messages.length.equals(30);
     final otherStream = eg.stream();
-    await store.handleEvent(MessageEvent(id: 0,
-      message: eg.streamMessage(stream: otherStream)));
+    await store.addMessage(eg.streamMessage(stream: otherStream));
     checkNotNotified();
     check(model).messages.length.equals(30);
   });
 
   test('MessageEvent, before fetch', () async {
     final stream = eg.stream();
     await prepare(narrow: ChannelNarrow(stream.streamId));
-    await store.handleEvent(MessageEvent(id: 0,
-      message: eg.streamMessage(stream: stream)));
+    await store.addMessage(eg.streamMessage(stream: stream));
     checkNotNotified();
     check(model).fetched.isFalse();
   });
@@ -1314,7 +1311,7 @@ void main() {
       }
 
       final message = eg.streamMessage(stream: stream, topic: 'hello');
-      await store.handleEvent(MessageEvent(id: 0, message: message));
+      await store.addMessage(message);
 
       await store.handleEvent(
         eg.reactionEvent(eg.unicodeEmojiReaction, ReactionOp.add, message.id));
@@ -1396,8 +1393,7 @@ void main() {
     await prepare(narrow: ChannelNarrow(stream.streamId));
     await prepareMessages(foundOldest: true, messages:
       List.generate(30, (i) => eg.streamMessage(stream: stream)));
-    await store.handleEvent(MessageEvent(id: 0,
-      message: eg.streamMessage(stream: stream)));
+    await store.addMessage(eg.streamMessage(stream: stream));
     checkNotifiedOnce();
     check(model).messages.length.equals(31);
 
@@ -1644,8 +1640,7 @@ void main() {
       await prepare(narrow: ChannelNarrow(stream.streamId));
       await prepareMessages(foundOldest: true, messages: []);
 
-      await store.handleEvent(MessageEvent(id: 0,
-        message: eg.streamMessage(stream: stream)));
+      await store.addMessage(eg.streamMessage(stream: stream));
       // Each [checkNotifiedOnce] call ensures there's been a [checkInvariants]
       // call, where the [ContentNode] gets checked.  The additional checks to
       // make this test explicit.
@@ -1659,13 +1654,13 @@ void main() {
       await prepare(narrow: ChannelNarrow(stream.streamId));
       await prepareMessages(foundOldest: true, messages: []);
 
-      await store.handleEvent(MessageEvent(id: 0, message: eg.streamMessage(
+      await store.addMessage(eg.streamMessage(
         stream: stream,
         sender: eg.selfUser,
         submessages: [
           eg.submessage(senderId: eg.selfUser.userId,
             content: eg.pollWidgetData(question: 'question', options: ['A'])),
-        ])));
+        ]));
       // Each [checkNotifiedOnce] call ensures there's been a [checkInvariants]
       // call, where the value of the [Poll] gets checked.  The additional
       // checks make this test explicit.

test/model/message_test.dart

@@ -71,9 +71,7 @@ void main() {
   }
 
   Future<void> addMessages(Iterable<Message> messages) async {
-    for (final m in messages) {
-      await store.handleEvent(MessageEvent(id: 0, message: m));
-    }
+    await store.addMessages(messages);
     checkNotified(count: messageList.fetched ? messages.length : 0);
   }
 

test/widgets/home_test.dart

@@ -2,7 +2,6 @@ import 'package:checks/checks.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_checks/flutter_checks.dart';
 import 'package:flutter_test/flutter_test.dart';
-import 'package:zulip/api/model/events.dart';
 import 'package:zulip/model/actions.dart';
 import 'package:zulip/model/narrow.dart';
 import 'package:zulip/model/store.dart';
@@ -72,8 +71,8 @@ void main () {
     testWidgets('preserve states when switching between views', (tester) async {
       await prepare(tester);
       await store.addUser(eg.otherUser);
-      await store.handleEvent(MessageEvent(
-        id: 0, message: eg.dmMessage(from: eg.otherUser, to: [eg.selfUser])));
+      await store.addMessage(
+        eg.dmMessage(from: eg.otherUser, to: [eg.selfUser]));
       await tester.pump();
 
       check(find.byIcon(ZulipIcons.arrow_down)).findsExactly(2);

test/widgets/inbox_test.dart

@@ -70,7 +70,7 @@ void main() {
 
     for (final message in unreadMessages) {
       assert(!message.flags.contains(MessageFlag.read));
-      await store.handleEvent(MessageEvent(id: 1, message: message));
+      await store.addMessage(message);
     }
 
     await tester.pumpWidget(TestZulipApp(

test/widgets/poll_test.dart

@@ -5,7 +5,6 @@ import 'package:http/http.dart' as http;
 import 'package:flutter/widgets.dart';
 import 'package:flutter_checks/flutter_checks.dart';
 import 'package:flutter_test/flutter_test.dart';
-import 'package:zulip/api/model/events.dart';
 import 'package:zulip/api/model/model.dart';
 import 'package:zulip/api/model/submessage.dart';
 import 'package:zulip/model/store.dart';
@@ -40,7 +39,7 @@ void main() {
     message = eg.streamMessage(
       sender: eg.selfUser,
       submessages: [eg.submessage(content: submessageContent)]);
-    await store.handleEvent(MessageEvent(id: 0, message: message));
+    await store.addMessage(message);
     await tester.pumpWidget(TestZulipApp(accountId: eg.selfAccount.id,
       child: PollWidget(messageId: message.id, poll: message.poll!)));
     await tester.pump();

test/widgets/recent_dm_conversations_test.dart

@@ -38,9 +38,7 @@ Future<void> setupPage(WidgetTester tester, {
     await store.addUser(user);
   }
 
-  for (final dmMessage in dmMessages) {
-    await store.handleEvent(MessageEvent(id: 1, message: dmMessage));
-  }
+  await store.addMessages(dmMessages);
 
   if (newNameForSelfUser != null) {
     await store.handleEvent(RealmUserUpdateEvent(id: 1, userId: eg.selfUser.userId,