Add duplicate mod import check and user-friendly error screen #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muddyfish
reviewed
Mar 28, 2025
|
|
||
| def add_mod(mod_name, mod): | ||
| """Add a mod in the registry""" | ||
| print "Adding mod {}".format(mod_name) | ||
| if mod_name in modlist: | ||
| print("IMPORT ISSUE: Given a mod name of {0!r} by both {1!r} and {2!r}.".format(mod_name, modlist[mod_name].__module__, mod.__module__)) |
There was a problem hiding this comment.
Was this print statement only for debugging?
There was a problem hiding this comment.
It was not. In case something goes wrong from the multiple import of these mods, I wanted to give some kind of output as soon as it's discovered, at least for mod developers, just in case they manage to create a corner case where we can't show the error screen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detects when mods are imported from multiple places, but their metadata reports the same name. Prevents the user/mod developer from launching the game fully until this name duplication has been resolved.
Without this, current behavior is to import the
__init__.pyand*.rpyfiles of both mods, but silently only callmod_loadandmod_completeon whichever mod was imported second. Without duplicate labels in*.rpyfiles, this could be entirely silent and result in numerous confusing behaviors.Credit to JoeyJumper94 for exposing this issue with a heisenbug that had different behavior on Linux vs Wine (due to different folder sort order.)