Skip to content

Update the services Part #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2021
Merged

Update the services Part #100

merged 1 commit into from
Jan 15, 2021

Conversation

TavoNiievez
Copy link
Member

@TavoNiievez TavoNiievez commented Jan 13, 2021

Just to be consistent, the services part is updated, which is the only one documented (and useful?).

The email part was never documented (or used?), so that excess annotation is removed as well.

@TavoNiievez TavoNiievez added this to the 2.0.0 milestone Jan 13, 2021
@TavoNiievez TavoNiievez added help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Jan 13, 2021
@TavoNiievez TavoNiievez marked this pull request as ready for review January 13, 2021 21:29
@Naktibalda
Copy link
Member

I guess you have a good answer to question why we need parts.

The idea for exposing a few methods via parts was to make them available when Symfony application is being tested using PhpBrowser or WebDriver.

Most of your new parts only make sense for functional testing using Symfony module.
Using those parts would hide all methods provided by InnerBrowser.

@TavoNiievez
Copy link
Member Author

TavoNiievez commented Jan 14, 2021

Ok, I know that some people use the services part in unit tests, and since it is the only Part that was documented up to now, it is the only one that I will update and maintain for version 2.0, thank you very much for your feedback.

@TavoNiievez TavoNiievez changed the title Better support for the Parts feature Update the services Parts Jan 15, 2021
@TavoNiievez TavoNiievez changed the title Update the services Parts Update the services Part Jan 15, 2021
@TavoNiievez TavoNiievez merged commit 7a16f96 into Codeception:master Jan 15, 2021
@TavoNiievez TavoNiievez deleted the better_parts_support branch January 15, 2021 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants