rebase extension.json work around new codebase #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lethosor
reviewed
Jan 2, 2023
|
c5b835b |
lethosor
reviewed
Jan 3, 2023
| "description": "Absolute path to raws directory, when empty use 'raws' directory in extension catalog" | ||
| "value": "raws", | ||
| "path": true, | ||
| "description": "Relative path to raws directory" |
There was a problem hiding this comment.
Couldn't it also be absolute? I don't see any checks for the path root in DFRawFunctions.body.php
There was a problem hiding this comment.
With "path": true mediawiki insert extension directory to path without any other checks.
So only relative.
fix problem with non evalable wgDFRawPath
remove missed __DIR__
Default str to int comparison behavior was changed in php8+ https://wiki.php.net/rfc/string_to_number_comparison with is caused undefined behavior in code. This commit fixes it by explicitly casting str to int.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differences from #7 :
Leave code in DFRawFunctions.body.php to make review more easily
Added $wgDFRawVersion varible, that define version with will be used if namespace is not set, that change required for Russian wiki that use only main user space, and should not affect English wiki.
Fixed problem with non evalable by default DFRawPath in extension.json by moving default path DIR . '/raws'; to code