-
Notifications
You must be signed in to change notification settings - Fork 20
feat: add a macro to directly visualize the generated mlir #1246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d47cca4
to
4279851
Compare
@mlir_visualize [optimize = ...] [no_nan = <true/false>] f(args...) | ||
|
||
Runs `@code_hlo` and visualizes the MLIR module using `model-explorer`. This expects the | ||
`model-explorer` executable to be in your `PATH`. Installation instructions can be found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this feels worthwhile just making into a (separate) jll of our own imo, rather than relying on path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, though it seems to be a JS framework, not sure how to ship the binary via yggy. @giordano might know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like https://github.com/JuliaPackaging/Yggdrasil/blob/179e92aaf902a50c7876b0d088b3de88091be228/D/D3/build_tarballs.jl? What's the executable? A script which requires an interpreter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I was mistaken, only the UI components are present in the npm package. https://github.com/google-ai-edge/model-explorer/blob/main/src/builtin-adapter/python/pip_package/build_pip_package.sh has the bazel scripts for the python wheel
default_options = Dict{Symbol,Any}( | ||
:optimize => true, | ||
:no_nan => false, | ||
:client => nothing, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tangentially from this PR, we should consider having these options defaults in one place (rather than copied many places)
Same as code_hlo but opens a browser session