Skip to content

Use .vec SVG class for vector_graphics_compiler transformed assets #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Albert221
Copy link

@Albert221 Albert221 commented May 10, 2025

What does this change?

In the SVG integration, assets that have a vector_graphics_compiler asset transformer will use SvgGenImage.vec constructor to use correct bytes loader.

Fixes #684 🎯

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
    • Ensure the tests (melos run test)
    • Ensure the analyzer and formatter pass (melos run format to automatically apply formatting)
  • Appropriate docs were updated (if necessary)

@Albert221 Albert221 force-pushed the feat/transformers-support branch 2 times, most recently from 7cb6b47 to 4471a49 Compare May 10, 2025 13:15
@Albert221 Albert221 marked this pull request as ready for review May 10, 2025 13:15
@Albert221
Copy link
Author

@AlexV525 should be ready now :)

@Albert221 Albert221 force-pushed the feat/transformers-support branch from 4471a49 to 3fb54fd Compare May 10, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: Support flutter_svg asset transformed files (vector_graphics_compiler)
1 participant