-
Notifications
You must be signed in to change notification settings - Fork 2
Fix ggshield retrieval with proxy #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
salome-voltz
merged 6 commits into
main
from
severine/fix-ggshield-retrieval-with-proxy
Apr 30, 2025
Merged
Fix ggshield retrieval with proxy #80
salome-voltz
merged 6 commits into
main
from
severine/fix-ggshield-retrieval-with-proxy
Apr 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5e7d39
to
b377fff
Compare
b377fff
to
b4ac271
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me ! thank you for the changes 🙏
I just have some minor remarks
salome-voltz
approved these changes
Apr 30, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Leveraging help from #79. (Thank you @GabrielCousin!)
This PR tentatively addresses certificate errors encountered by customers when installing the extension.
Error logs looked like this:
or
What has been done
axios
instead ofsync-request
lib to make HTTP calls to github APIrejectUnauthorized
fromaxios
to disable SSL checks when option "allow self-signed certificate" is checked on the extension.getGGShieldLatestVersion
as it's not used anymore.prettier
version in pre-commit as it was not up-to-date with typescript version in this repo.Best reviewed commit by commit.
Validation
I tried validating this using
mitmproxy
. Unfortunately I wasn't able to tweak it to make ggshield-download step fail on SSL certificate grounds.So I haven't been able to confirm this line will fix encountered issues with proxy.
However, please note that this confirms the fix should work. So I think we can have a good confidence it will work.
Also, I was able to validate locally that changes here don't affect the standard behavior of the extension.
ggshield-internal
folder if it existsIn conclusion,
PR check list