Skip to content

Add Sales Grid implementation. #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 17, 2025
Merged

Add Sales Grid implementation. #9

merged 14 commits into from
Apr 17, 2025

Conversation

skrustev
Copy link
Member

@skrustev skrustev commented Mar 27, 2025

There are currently 2 issues that need to be resolved for this PR:

  1. Excel exporters are not available and there's already PR for it:
    feat(elements): Add excel and csv exporters to elements. igniteui-angular#15611
  2. Setting headerTemplate during columnInit event breaks the grid and there are errors:
    fix(elements): Handle template setting of components passed as event args through proxy.  igniteui-angular#15649

Fixes IgniteUI/grid-demos#105 for WC as well.

@skrustev skrustev marked this pull request as ready for review April 14, 2025 07:42
@mddragnev
Copy link
Member

Found 3 things:

  1. Grid Height is not 100% of the viewport.
  2. When changing views from the views dropdown nothing happens. It stays on the first view.
  3. On the main view -> Remove Brand column -> an error is thrown

@skrustev skrustev requested a review from mddragnev April 15, 2025 07:15
@MayaKirova MayaKirova added the 💥 status: in-test PRs currently being tested label Apr 16, 2025
@MayaKirova
Copy link

In the sample itself:

  • Small issue I noticed is that if you configure the pivot so that it has some empty values (Rows: All Periods + Country, Columns: Brand, Store), it shows them as $NaN:
    image
    While in the angular sample, it shows an empty cell, which looks better.

In the whole app:

  • When running npm run build there are some error thrown from the sample:
    image

  • When running the full app npm run dev and navigating to the target sample, there seems to be an issue with the theming:

image

@MayaKirova MayaKirova self-assigned this Apr 16, 2025
@skrustev skrustev added 🛠️ status: in-development Issues and PRs with active development on them and removed 💥 status: in-test PRs currently being tested labels Apr 17, 2025
@skrustev skrustev added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Apr 17, 2025
@MayaKirova MayaKirova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Apr 17, 2025
@MayaKirova
Copy link

When run in preview, there are some errors and the data does not load:

image

If I remove the filter "Brands" it shows the data correctly.

@MayaKirova
Copy link

MayaKirova commented Apr 17, 2025

Also when running the individual sample, for some reason while dragging a chip it disappears:

chip-where

It then appears when you drop it.

@skrustev
Copy link
Member Author

skrustev commented Apr 17, 2025

T he issue with chips should be fixed now.
For the data loading make sure you install the latest packages in the projects run.

@skrustev skrustev added ❌ status: awaiting-test PRs awaiting manual verification and removed 💥 status: in-test PRs currently being tested labels Apr 17, 2025
@dkamburov dkamburov added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Apr 17, 2025
@mddragnev mddragnev self-requested a review April 17, 2025 13:50
@dkamburov dkamburov merged commit 3ca7297 into vnext Apr 17, 2025
2 checks passed
@dkamburov dkamburov deleted the skrastev/sales-grid branch April 17, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sales Grid export to CSV not working as expected.
4 participants