Skip to content

Avoid overflow in linspace test #2451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 15, 2025
Merged

Avoid overflow in linspace test #2451

merged 3 commits into from
May 15, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented May 14, 2025 •
edited
Loading

The PR resolves overflow issue observing in test_linspace_mixed_start_stop2 test when running with DPNP_TEST_ALL_INT_TYPES=1 on ARL-S machine.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy self-assigned this May 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2451/index.html

@coveralls
Copy link
Collaborator

coveralls commented May 14, 2025 •
edited
Loading

Coverage Status

coverage: 71.711%. remained the same
when pulling 5251b7d on avoid-overflow-in-linspace-test
into 8b4a332 on master.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 14, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.18.0dev2=py312he4f9c94_17 ran successfully.
Passed: 1229
Failed: 0
Skipped: 9

@antonwolfy antonwolfy merged commit c4dab5d into master May 15, 2025
63 of 68 checks passed
@antonwolfy antonwolfy deleted the avoid-overflow-in-linspace-test branch May 15, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonwolfy @coveralls @vtavana