Skip to content

[LibLz4] Add LZ4 HDF5 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[LibLz4] Add LZ4 HDF5 #27

wants to merge 4 commits into from

Conversation

nhz2
Copy link
Member

@nhz2 nhz2 commented Mar 23, 2025

This is an implementation of the LZ4 HDF5 format based on HDFGroup/hdf5_plugins#173

This PR has tests for compatibility with https://github.com/JuliaIO/HDF5.jl/blob/master/ext/CodecLz4Ext/CodecLz4Ext.jl

imagecodecs compatibility is currently broken due to a bug in imagecodecs: cgohlke/imagecodecs#126

It would be good to test compatibility with the C code in https://github.com/HDFGroup/hdf5_plugins but I'm unsure how to set that up.

CC @mkitti

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 98.51852% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.32%. Comparing base (069e023) to head (3b1e47b).

Files with missing lines Patch % Lines
LibLz4/src/decode.jl 98.55% 1 Missing ⚠️
LibLz4/src/encode.jl 98.43% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   95.42%   96.32%   +0.90%     
==========================================
  Files           5        5              
  Lines         328      463     +135     
==========================================
+ Hits          313      446     +133     
- Misses         15       17       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants