Skip to content

this is my excel to cvs code #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

this is my excel to cvs code #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions R/Nancy Clarin/excel_to_csv.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
slx <- read_excel("/home/clarinnancy/tickets/Hamilton2016/Alaska_place_time_16b (1).xls")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should always include your library calls (package dependencies) at the top of every R script that you write. This way your code is more reproducible (you can run this script on its own) and other people can run it easily

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additionally - I would fix the (1) on your filenames. It is not good practice to name files with spaces and parentheses (even if you downloads folder does it for you all the time). I always am in the practice of renaming files once I upload them onto the server.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
slx <- read_excel("/home/clarinnancy/tickets/Hamilton2016/Alaska_place_time_16b (1).xls")
library(readxl)
slx <- read_excel("/home/clarinnancy/tickets/Hamilton2016/Alaska_place_time_16b (1).xls")

slx <- as.data.frame(slx)
write.csv(slx,"/home/clarinnancy/tickets/Hamilton2016/alaska_place_time.csv", row.names = FALSE)