Pin to v2.4.4 with easy updates in future #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeteBishwhip
force-pushed
the
bugfix/pin-spc
branch
from
9fe2c38 to
8f86638
Compare
|
https://github.com/NativePHP/php-bin/actions/runs/13948445135 Demonstrating a now working build |
simonhamp
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
.github/workflows/build-php.ymlfile to address issues with the SPC version and improve the build process. The most important changes include setting a specific SPC version, updating SPC URLs for different operating systems, and adding a debug flag to the build command.Environment variable updates:
SPC_VERSIONandWINBUILD_ACKNOWLEDGE_DEPRECATEDenvironment variables to address a temporary workaround for an issue with SPC versioning.SPC URL updates:
macos-13,macos-latest,ubuntu-latest,ubuntu-24.04-arm, andwindows-latestto use the new SPC version-specific URLs from GitHub releases.Build process improvement:
--debugflag to the PHP build command to enable debug mode during the build process.Fixes NativePHP/laravel#522