allow the use of LAPACK_COMPLEX_CPP when using MSVC compiler #5244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MSVC is clearly not my forte, but I added this in response to #4073 - would we need an MSVC version check here perhaps ? |
|
I guess we do not need a version check for MSVC, I checked that std::complex is present all the way back in visual studio .net 2003. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, openblas force the use
complex.hwhen building lapack for msvc, this commit allow it to also use the C++complexusingLAPACK_COMPLEX_CPPmacro as it is in the non msvc case.