[fix]: permute_021 copy fix #1993
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: root <[email protected]>
|
Jenkins build for 117fd2e2b3296b0f528e280d5f16a8b6ef9b8d87 commit finished as FAILURE |
lcskrishna
reviewed
Mar 25, 2025
| @@ -150,7 +150,7 @@ bool is_permute_021(TensorIteratorBase &iter) { | |||
| is_permute &= input.stride(0) == input.size(2) * input.stride(2); | |||
| is_permute &= input.stride(1) == 1; | |||
| is_permute &= input.stride(2) >= input.size(1); | |||
| is_permute &= output.is_contiguous(); | |||
| is_permute &= output.is_contiguous() && !input.is_contiguous(); | |||
There was a problem hiding this comment.
The is_permute_021 function should detect whether the input tensor has its last two dimensions in transposed order. But for input shapes of (n, 1, 1), these are inherently contiguous cases that need to be excluded from consideration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix copy error in permute 021 case