-
Notifications
You must be signed in to change notification settings - Fork 68
[rocm6.5_internal_testing] Update kineto rocprof commit (#2015) #2052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rocm6.5_internal_testing] Update kineto rocprof commit (#2015) #2052
Conversation
Jenkins build for 6082afb8084faac031cebabf594df5fa36b4c325 commit finished as FAILURE Detected error during Pytorch building:
|
Use kineto workaround for non-amd systems (cherry picked from commit 402deb2)
f942383
to
6082afb
Compare
Jenkins build for 6082afb8084faac031cebabf594df5fa36b4c325 commit finished as FAILURE Detected error during Pytorch building:
|
@dnikolaev-amd , |
Jenkins build for 6082afb8084faac031cebabf594df5fa36b4c325 commit finished as FAILURE Detected error during Pytorch building:
|
fixed in the next commit |
Jenkins build for 141e3a69cd3d74d94b9b3c36f9dd6ad621d885e2 commit finished as FAILURE |
.gitmodules
Outdated
@@ -87,7 +87,8 @@ | |||
url = https://github.com/NVIDIA/cudnn-frontend.git | |||
[submodule "third_party/kineto"] | |||
path = third_party/kineto | |||
url = https://github.com/pytorch/kineto | |||
url = https://github.com/ROCm/kineto.git | |||
branch = rocprof_sdk_rocm6.5_internal_testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should have the branch name in the .gitmodules
file. Instead we should bump the submodule commit as and when needed, to have a consistent commit be used for the submodule. So I'm removing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
change kineto repo to ROCm
Use kineto workaround for non-amd systems
(cherry picked from commit 402deb2)